ITS: MultiRof seeding Vertexer #13125

mconcas · 2024-05-10T12:37:39Z

No description provided.

github-actions · 2024-05-10T12:37:59Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted
async-2024-pp-apass1
async-2024-pp-apass1-accepted
async-2022-pp-apass7
async-2022-pp-apass7-accepted
async-2024-pp-cpass0
async-2024-pp-cpass0-accepted

alibuild · 2024-05-15T14:51:49Z

Error while checking build/O2/fullCI for 1b81ea3 at 2024-05-15 16:51:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("o2::dataformats::Vertex< ::o2::dataformats::TimeStamp<int> > ::getTimeStamp() const") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("_ZNK2o211dataformats9TimeStampI1?E12getTimeStampEv") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TimeFrameGPU.h(317): error: identifier "mROframesClusters" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/TimeFrameGPU.cu(446): error: identifier "mROframesClusters" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/TimeFrameGPU.cu(456): error: identifier "mROframesClusters" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/TimeFrameGPU.cu(460): error: identifier "mROframesPV" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TimeFrameGPU.h:317:27: error: 'mROframesClusters' was not declared in this scope; did you mean 'mROFramesClusters'?
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("o2::dataformats::Vertex< ::o2::dataformats::TimeStamp<int> > ::getTimeStamp() const") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("_ZNK2o211dataformats9TimeStampI1?E12getTimeStampEv") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TimeFrameGPU.h(317): error: identifier "mROframesClusters" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("o2::dataformats::Vertex< ::o2::dataformats::TimeStamp<int> > ::getTimeStamp() const") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/TimeFrame.h(700): error: calling a __device__ function("_ZNK2o211dataformats9TimeStampI1?E12getTimeStampEv") from a __host__ function("insertLateVertex") is not allowed
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/ITStrackingGPU/TimeFrameGPU.h(317): error: identifier "mROframesClusters" is undefined
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/VertexerTraitsGPU.cu(726): error: class "o2::its::gpu::TimeFrameGPU<7>" has no member "getROframeClusters"
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/VertexerTraitsGPU.cu(726): error: class "o2::its::gpu::TimeFrameGPU<7>" has no member "getROframeClusters"
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/VertexerTraitsGPU.cu(727): error: class "o2::its::gpu::TimeFrameGPU<7>" has no member "getROframeClusters"
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/VertexerTraitsGPU.cu(727): error: class "o2::its::gpu::TimeFrameGPU<7>" has no member "getROframeClusters"
/sw/SOURCES/O2/13125-slc8_x86-64/0/Detectors/ITSMFT/ITS/tracking/GPU/cuda/VertexerTraitsGPU.cu(730): error: "gsl::span<ElementType, Extent>::span(gsl::span<ElementType, Extent>::KnownNotNull, gsl::span<ElementType, Extent>::size_type) noexcept [with ElementType=const o2::its::Line, Extent=18446744073709551615UL]" (declared at line 706 of /sw/slc8_x86-64/ms_gsl/4.0.0-30/include/gsl/span) is inaccessible
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-05-21T03:02:26Z

Error while checking build/O2/fullCI for f3b91b1 at 2024-05-21 05:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.log[ERROR] Workflow crashed - PID 29257 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device tof-matcher: pid 29257 (exit 128)
./sim-challenge.log[ERROR] SEVERE: Device tof-matcher (29257) returned with 128
./midreco.log[21382:MIDRecoWriter]: [02:59:57][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7675:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[7676:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[7677:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
[0 more errors; see full log]

Full log here.

mconcas added 2 commits April 23, 2024 19:26

Add multi rof vertexer idea

b42bd17

TrackletFinder extended, slection is still bugged

f926c03

mconcas force-pushed the dev branch from 1f30b96 to d0e6d9e Compare May 10, 2024 12:40

More vertices is better than less

6d1d3b5

mconcas force-pushed the dev branch from d0e6d9e to 6d1d3b5 Compare May 10, 2024 13:00

Improve tracklet validation and manage late vertices

1b81ea3

mconcas force-pushed the dev branch from be88bf6 to 1b81ea3 Compare May 15, 2024 14:15

mconcas marked this pull request as ready for review May 15, 2024 14:16

mconcas requested review from fgrosa, arossi81, f3sch and shahor02 as code owners May 15, 2024 14:16

mconcas changed the title ~~[WIP] ITS: MultiRof seeding Vertexer~~ ITS: MultiRof seeding Vertexer May 15, 2024

Fix GPU compilation

f3b91b1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITS: MultiRof seeding Vertexer #13125

ITS: MultiRof seeding Vertexer #13125

mconcas commented May 10, 2024 •

edited

github-actions bot commented May 10, 2024

alibuild commented May 15, 2024

alibuild commented May 21, 2024

ITS: MultiRof seeding Vertexer #13125

Are you sure you want to change the base?

ITS: MultiRof seeding Vertexer #13125

Conversation

mconcas commented May 10, 2024 • edited

github-actions bot commented May 10, 2024

alibuild commented May 15, 2024

alibuild commented May 21, 2024

mconcas commented May 10, 2024 •

edited