add trk res in TOF match chi2 #13058

noferini · 2024-04-21T09:28:12Z

For the moment I assumed that:

trk errors are given in the sector reference system
Y -> direction along phi wrt sector r.s.
Z -> direction along Z (error to be projected considering strip inclination)

matchable output updated with errors info to test different matching algorithms for improvements

Note that all variables added to MatchInfoTOFReco
are stored only in matchable (debug) output (if requested). For matching standard ouput MatchInfoTOF is used

github-actions · 2024-04-21T09:28:21Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

noferini · 2024-04-22T16:06:11Z

Hi @shahor02 ,
I was wondering if you can run again on your Pb-Pb apass3 outputs with this PR, and produce o2matchable_tof.root.
It would be very useful to start to tune matching algorithm.
Cheers,
Francesco

shahor02 · 2024-04-22T16:39:56Z

@noferini shall I merge it 1st or you are still modifying it?

noferini · 2024-04-22T16:42:48Z

@noferini shall I merge it 1st or you are still modifying it?

@shahor02 , I would not merge it for the moment since it is still wip (I removed wip to check compilation).
If you can run it without merging is the best

davidrohr · 2024-04-23T09:07:52Z

@noferini : If you don't want it to be merged and you remove WIP, then please put something like - DO NOT MERGE in the title of the PR :).

shahor02 · 2024-04-23T10:23:41Z

@noferini https://cernbox.cern.ch/s/5U24GEsOzVPxltR is the o2matchable_tof.root for 38kHz run LHC23zzk_544508, let me know if you need other data.

noferini · 2024-04-23T10:36:23Z

@noferini https://cernbox.cern.ch/s/5U24GEsOzVPxltR is the o2matchable_tof.root for 38kHz run LHC23zzk_544508, let me know if you need other data.

Many thanks!
Running on it

alibuild · 2024-04-23T18:21:41Z

Error while checking build/O2/fullCI for e37249e at 2024-05-02 00:14:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep ' error:'
++ grep -v clang-diagnostic-error error-log.txt
/sw/SOURCES/O2/13058-slc8_x86-64/0/Framework/Core/include/Framework/ASoA.h:3115:81: error: invalid use of incomplete type 'typename table_t::RowViewFiltered<Filtered<Join<aod::Tracks, aod::TracksExtra>>, TracksExtension, Table<Index<0, -1>, CollisionId, TrackType, X, Alpha, Y, Z, Snp, Tgl, Signed1Pt, IsWithinBeamPipe<X>, Px<Signed1Pt, Snp, Alpha>, Py<Signed1Pt, Snp, Alpha>, Pz<Signed1Pt, Tgl>, PVector<Signed1Pt, Snp, Alpha, Tgl>, Energy<Signed1Pt, Tgl>, Rapidity<Signed1Pt, Tgl>, Sign<Signed1Pt>, Marker<1>>, TracksExtra_001Extension, Table<TPCInnerParam, Flags, ITSClusterSizes, TPCNClsFindable, TPCNClsFindableMinusFound, TPCNClsFindableMinusCrossedRows, TPCNClsShared, TRDPattern, ITSChi2NCl, TPCChi2NCl, TRDChi2, TOFChi2, TPCSignal, TRDSignal, Length, TOFExpMom, PIDForTracking<Flags>, IsPVContributor<Flags>, HasITS<DetectorMap>, HasTPC<DetectorMap>, HasTRD<DetectorMap>, HasTOF<DetectorMap>, TPCNClsFound<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCNClsCrossedRows<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, ITSClusterMap<ITSClusterSizes>, ITSNCls<ITSClusterSizes>, ITSNClsInnerBarrel<ITSClusterSizes>, ITSClsSizeInLayer<ITSClusterSizes>, TPCCrossedRowsOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusCrossedRows>, TPCFoundOverFindableCls<TPCNClsFindable, TPCNClsFindableMinusFound>, TPCFractionSharedCls<TPCNClsShared, TPCNClsFindable, TPCNClsFindableMinusFound>, TrackEtaEMCAL, TrackPhiEMCAL, TrackTime, TrackTimeRes>>' (aka 'RowViewBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::Join<aod::Tracks, aod::TracksExtra>>, o2::aod::TracksExtension, o2::soa::Table<o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::PVector<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1>>, o2::aod::TracksExtra_001Extension, o2::soa::Table<o2::aod::track::TPCInnerParam, o2::aod::track::Flags, o2::aod::track::ITSClusterSizes, o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound, o2::aod::track::TPCNClsFindableMinusCrossedRows, o2::aod::track::TPCNClsShared, o2::aod::track::TRDPattern, o2::aod::track::ITSChi2NCl, o2::aod::track::TPCChi2NCl, o2::aod::track::TRDChi2, o2::aod::track::TOFChi2, o2::aod::track::TPCSignal, o2::aod::track::TRDSignal, o2::aod::track::Length, o2::aod::track::TOFExpMom, o2::aod::track::PIDForTracking<o2::aod::track::Flags>, o2::aod::track::IsPVContributor<o2::aod::track::Flags>, o2::aod::track::HasITS<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTPC<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTRD<o2::aod::track::v001::DetectorMap>, o2::aod::track::HasTOF<o2::aod::track::v001::DetectorMap>, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>, o2::aod::track::TPCNClsCrossedRows<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::v001::ITSClusterMap<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNCls<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSNClsInnerBarrel<o2::aod::track::ITSClusterSizes>, o2::aod::track::v001::ITSClsSizeInLayer<o2::aod::track::ITSClusterSizes>, o2::aod::track::TPCCrossedRowsOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusCrossedRows>, o2::aod::track::TPCFoundOverFindableCls<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound/sw/SOURCES/O2/13058-slc8_x86-64/0/Framework/Core/include/Framework/ASoA.h:1401:114: note: in instantiation of template class 'o2::soa::Filtered<o2::soa::Join<o2::aod::TracksCovIUExtension, o2::soa::Table<o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<2>>>>' requested here
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild · 2024-05-07T12:49:05Z

Error while checking build/O2/fullCI for bd7749a at 2024-05-07 14:49:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1055:78: error: '__gnu_cxx::__alloc_traits<std::allocator<o2::dataformats::MatchInfoTOFReco>, o2::dataformats::MatchInfoTOFReco>::value_type' {aka 'class o2::dataformats::MatchInfoTOFReco'} has no member named 'setVz2'; did you mean 'setVz'?
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1396:233: error: 'deltat' was not declared in this scope
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1401:110: error: 'Zshift' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-05-07T13:20:40Z

Error while checking build/O2/fullCI for d9f2e2c at 2024-05-07 15:20:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1055:79: error: '__gnu_cxx::__alloc_traits<std::allocator<o2::dataformats::MatchInfoTOFReco>, o2::dataformats::MatchInfoTOFReco>::value_type' {aka 'class o2::dataformats::MatchInfoTOFReco'} has no member named 'setVz2'; did you mean 'setVz'?
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1396:233: error: 'deltat' was not declared in this scope
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1401:111: error: 'Zshift' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2024-05-07T15:55:02Z

Error while checking build/O2/fullCI for 1969664 at 2024-05-07 17:55:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/SOURCES/O2/13058-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchTOF.cxx:1400:233: error: 'deltat' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

noferini · 2024-05-13T19:39:16Z

I think we can start the review.

Note that in BestMatches I added the possibility (for constrained tracks) to match up to 2 clusters in different strips if times are within 200 ps.
In that case (4% of the cases, estimated in pp) time is returned as the average of the two (the second one corrected for the difference in the track length). Such cases are flagged as chi2=0

Detectors/GlobalTracking/src/MatchTOF.cxx

noferini · 2024-05-16T09:19:46Z

All done from my side.
One check (macos) failing due to a git error not related to this PR.
Cheers,
Francesco

shahor02 · 2024-05-16T09:24:55Z

Thanks @noferini , do you have some plot showing the fakes contamination with new and old method?

noferini · 2024-05-16T09:31:37Z

Thanks @noferini , do you have some plot showing the fakes contamination with new and old method?

In principle, the performance are the one reported in my presentation
https://indico.cern.ch/event/1406660/contributions/5912002/attachments/2851047/4985149/TOF%20Sim&Reco&QC%20-%207may24.pdf

baset on the matchable output you sent me for Pb-Pb
However, I am not able to run any test locally without a full output from reconstruction.
If you still have the full output of that Pb-Pb reconstruction (ITS,TPC tracks + tofclusters + ITSTPC matching + TRD matches + TOF matches) I can re-run the full matching and compare

noferini · 2024-05-16T09:32:49Z

Otherwise, I can ask Catalin to run a debug production on the GRID

noferini · 2024-05-16T11:48:35Z

In the meanwhile I realized that I was storing residuals as used in the new Chi2 definition.
I changed it to store original residuals since they may be needed for alignment.

shahor02 · 2024-05-16T18:48:09Z

Hi @noferini
I've deleted the previous full reco and now have the one with new TPC settings AliceO2Group/O2DPG#1624, for 39 kHz run 544508 and 7kHz run 544124. But the files are too large to copy them somewhere. Shall I simply re-run the TOF matching with this PR and provide you the result of checkMatch.C ?

noferini · 2024-05-17T07:12:13Z

Hi @shahor02 , I prefer to use the full output to be sure that I use exactly the same code.
I've already asked @chiarazampolli and @catalinristea if we can do a small debug production on the GRID.

shahor02 · 2024-05-17T07:40:12Z

Ok, so I merge it as is?

noferini · 2024-05-17T07:41:27Z

At this point I will wait till Monday if I manage to have a full validation on debug production

shahor02 · 2024-05-17T07:52:15Z

Don't you need a tag for the grid debug production?

noferini · 2024-05-17T07:57:52Z

Don't you need a tag for the grid debug production?

No, once I have the full output I can re-run locally with the possibility to try different KeyParams configurations.

alibuild · 2024-05-19T14:05:22Z

Error while checking build/O2/fullCI for e1c2638 at 2024-05-19 16:05:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-sim-challenge-test-latest/log
./tofMatchTracks.log[ERROR] Workflow crashed - PID 29808 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./tofMatchTracks.log[ERROR]  - Device tof-matcher: pid 29808 (exit 128)
./tofMatchTracks.log[ERROR] SEVERE: Device tof-matcher (29808) returned with 128
./mchreco.log[18723:mch-error-writer]: [14:01:55][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./mchreco.log[18724:mch-track-writer]: [14:01:55][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./mchmidMatch.log[22740:muon-track-writer]: [14:02:49][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
./sim-challenge.log[ERROR] Workflow crashed - PID 29808 (tof-matcher) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device tof-matcher: pid 29808 (exit 128)
./sim-challenge.log[ERROR] SEVERE: Device tof-matcher (29808) returned with 128
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[9739:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[9757:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[9762:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[9762:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[9762:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[9762:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
[0 more errors; see full log]

Full log here.

noferini · 2024-05-19T19:21:05Z

So far I managed to check ITS-TPC matching in Pb-Pb apass2 (debug prods).
run: 544124 (at start of run) -> IR = 8.5 kHz
I used ITS-TPC tracks since at that time there was a in issue with TRD fixed before of apass3.
source: o2match_tof_itstpc.root using different matching algorithms
This is an example how the mismatch (dotted lines) is extracted by fitting t-texp for different cases (fit works very well)

noferini · 2024-05-19T19:26:10Z

0.2 < p_{T} < 0.5 GeV/c
#chi^{2} < 10: mism = 69%
Res < 10 cm: mism = 81%
#chi^{2} < 5: mism = 66%
Res < 3 cm: mism = 61%
#chi^{2} < 3: mism = 63%

0.5 < p_{T} < 0.8 GeV/c
#chi^{2} < 10: mism = 54%
Res < 10 cm: mism = 60%
#chi^{2} < 5: mism = 50%
Res < 3 cm: mism = 40%
#chi^{2} < 3: mism = 47%

0.8 < p_{T} < 1.0 GeV/c
#chi^{2} < 10: mism = 37%
Res < 10 cm: mism = 47%
#chi^{2} < 5: mism = 33%
Res < 3 cm: mism = 24%
#chi^{2} < 3: mism = 29%

1.0 < p_{T} < 1.2 GeV/c
#chi^{2} < 10: mism = 40%
Res < 10 cm: mism = 48%
#chi^{2} < 5: mism = 35%
Res < 3 cm: mism = 22%
#chi^{2} < 3: mism = 31%

1.2 < p_{T} < 1.5 GeV/c
#chi^{2} < 10: mism = 35%
Res < 10 cm: mism = 44%
#chi^{2} < 5: mism = 29%
Res < 3 cm: mism = 19%
#chi^{2} < 3: mism = 26%

1.5 < p_{T} < 1.8 GeV/c
#chi^{2} < 10: mism = 29%
Res < 10 cm: mism = 36%
#chi^{2} < 5: mism = 24%
Res < 3 cm: mism = 13%
#chi^{2} < 3: mism = 22%

noferini · 2024-05-19T19:35:04Z

A example of the mism vs efficiency for reference

0.8 < p_{T} < 1.0 GeV/c
#chi^{2} < 10: mism = 37% -- eff = 100%
Res < 10 cm: mism = 47% -- eff = 98%
#chi^{2} < 5: mism = 33% -- eff = 95%
Res < 3 cm: mism = 24% -- eff = 71%
#chi^{2} < 3: mism = 29% -- eff = 91%

It is consistent with what already presented here
https://indico.cern.ch/event/1406660/contributions/5912002/attachments/2851047/4985149/TOF%20Sim&Reco&QC%20-%207may24.pdf

I think we can merge. In any case parameters can be tuned now via keyParams

shahor02 · 2024-05-19T19:45:22Z

Thanks! Given the amount of mismatches, I think we should introduce a stricter time-difference cut, at least for apass. Anyway, merging.

noferini requested a review from shahor02 as a code owner April 21, 2024 09:28

noferini force-pushed the dev branch from 22bbd7e to e37249e Compare April 22, 2024 10:28

noferini changed the title ~~[WIP] add trk res in TOF match chi2~~ add trk res in TOF match chi2 Apr 22, 2024

noferini changed the title ~~add trk res in TOF match chi2~~ add trk res in TOF match chi2 - DO NOT MERGE Apr 23, 2024

noferini force-pushed the dev branch 2 times, most recently from bd7749a to d9f2e2c Compare May 7, 2024 12:23

noferini force-pushed the dev branch from d9f2e2c to 1969664 Compare May 7, 2024 15:14

noferini force-pushed the dev branch 2 times, most recently from 1905aa5 to ddf7edd Compare May 13, 2024 19:28

noferini changed the title ~~add trk res in TOF match chi2 - DO NOT MERGE~~ add trk res in TOF match chi2 May 13, 2024

add trk res in TOF match chi2

6b1a12e

noferini force-pushed the dev branch from ddf7edd to 6b1a12e Compare May 13, 2024 19:41

shahor02 reviewed May 13, 2024

View reviewed changes

Detectors/GlobalTracking/src/MatchTOF.cxx Show resolved Hide resolved

Detectors/GlobalTracking/src/MatchTOF.cxx Show resolved Hide resolved

Detectors/GlobalTracking/src/MatchTOF.cxx Show resolved Hide resolved

Detectors/GlobalTracking/src/MatchTOF.cxx Show resolved Hide resolved

noferini force-pushed the dev branch from dbf5316 to 7ead73a Compare May 14, 2024 12:33

noferini added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label May 15, 2024

reading TOF time from matchInfo instead of clusters

e1c2638

noferini force-pushed the dev branch from 7ead73a to e1c2638 Compare May 16, 2024 11:47

shahor02 merged commit e952633 into AliceO2Group:dev May 19, 2024
10 of 12 checks passed

benedikt-voelkel added the async-2023-pbpb-apass4-accepted Ported to async-2023-pbpb-apass4 label May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add trk res in TOF match chi2 #13058

add trk res in TOF match chi2 #13058

noferini commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

noferini commented Apr 22, 2024

shahor02 commented Apr 22, 2024

noferini commented Apr 22, 2024

davidrohr commented Apr 23, 2024

shahor02 commented Apr 23, 2024

noferini commented Apr 23, 2024

alibuild commented Apr 23, 2024 •

edited

alibuild commented May 7, 2024

alibuild commented May 7, 2024

alibuild commented May 7, 2024

noferini commented May 13, 2024

noferini commented May 16, 2024

shahor02 commented May 16, 2024

noferini commented May 16, 2024

noferini commented May 16, 2024

noferini commented May 16, 2024

shahor02 commented May 16, 2024

noferini commented May 17, 2024

shahor02 commented May 17, 2024

noferini commented May 17, 2024

shahor02 commented May 17, 2024

noferini commented May 17, 2024

alibuild commented May 19, 2024

noferini commented May 19, 2024

noferini commented May 19, 2024 •

edited

noferini commented May 19, 2024 •

edited

shahor02 commented May 19, 2024

add trk res in TOF match chi2 #13058

add trk res in TOF match chi2 #13058

Conversation

noferini commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

noferini commented Apr 22, 2024

shahor02 commented Apr 22, 2024

noferini commented Apr 22, 2024

davidrohr commented Apr 23, 2024

shahor02 commented Apr 23, 2024

noferini commented Apr 23, 2024

alibuild commented Apr 23, 2024 • edited

alibuild commented May 7, 2024

alibuild commented May 7, 2024

alibuild commented May 7, 2024

noferini commented May 13, 2024

noferini commented May 16, 2024

shahor02 commented May 16, 2024

noferini commented May 16, 2024

noferini commented May 16, 2024

noferini commented May 16, 2024

shahor02 commented May 16, 2024

noferini commented May 17, 2024

shahor02 commented May 17, 2024

noferini commented May 17, 2024

shahor02 commented May 17, 2024

noferini commented May 17, 2024

alibuild commented May 19, 2024

noferini commented May 19, 2024

noferini commented May 19, 2024 • edited

noferini commented May 19, 2024 • edited

shahor02 commented May 19, 2024

alibuild commented Apr 23, 2024 •

edited

noferini commented May 19, 2024 •

edited

noferini commented May 19, 2024 •

edited