Update of TPC Splines: non-uniform grid for TPC residuals #13042
+778
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI for 1b64788 at 2024-04-25 20:50: Full log here. |
|
Seems like fullCI is having some unrelated problems. |
sgorbuno
force-pushed
the
splines
branch
2 times, most recently
from
4ddd7a0
to
a9b3754
Compare
|
Error while checking build/O2/fullCI for a9b3754 at 2024-05-21 14:29: Full log here. |
|
@sgorbuno , unfortunately this did not work. I guess code parts that are not supposed to run on GPU need protection. I think default header files will not work, I overlooked that. If min / max etc. is supposed to run also on GPU you could use https://github.com/AliceO2Group/AliceO2/blob/dev/GPU/Common/GPUCommonMath.h#L331. Please check what would be appropriate. |
|
Hi @wiechula , I'm not allowed to see the build log when clicking on "Details": "Unauthorized to log in. A missing role is required to access this application. Please contact the application owner to get access." Can it be fixed? |
wiechula
reviewed
May 22, 2024
Comment on lines
+151
to
+181
| if (1) { // read transformation from the file | ||
|
|
||
| // const char* fileName = "master/out.root"; | ||
|
|
||
| const char* fileName = outFileName; | ||
|
|
||
| std::cout << "load corrections from file " << fileName << std::endl; | ||
|
|
||
| fastTransform->cloneFromObject(*TPCFastTransform::loadFromFile(fileName, "ccdb_object"), nullptr); | ||
|
|
||
| o2::gpu::TPCFastSpaceChargeCorrection& corr = fastTransform->getCorrection(); | ||
|
|
||
| if (0) { | ||
| std::cout << "check the loaded correction ..." << std::endl; | ||
|
|
||
| const o2::gpu::TPCFastTransformGeo& geo = helper->getGeometry(); | ||
|
|
||
| // for (int iRoc = 0; iRoc < geo.getNumberOfSlices(); iRoc++) { | ||
| for (int iRoc = 0; iRoc < 1; iRoc++) { | ||
| for (int iRow = 0; iRow < geo.getNumberOfRows(); iRow++) { | ||
| auto& info = corr.getSliceRowInfo(iRoc, iRow); | ||
| std::cout << "roc " << iRoc << " row " << iRow | ||
| << " gridV0 " << info.gridV0 << " gridCorrU0 " << info.gridCorrU0 << " gridCorrV0 " << info.gridCorrV0 | ||
| << " scaleCorrUtoGrid " << info.scaleCorrUtoGrid << " scaleCorrVtoGrid " << info.scaleCorrVtoGrid | ||
| << " gridU0 " << info.gridU0 << " scaleUtoGrid " << info.scaleUtoGrid << " scaleVtoGrid " << info.scaleVtoGrid | ||
| << std::endl; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are the data written to file and read back?
Is this only for debugging? If so, please add a comment.
Comment on lines
+218
to
+226
| // duplicate of debugVox | ||
| debugFile->cd(); | ||
| TNtuple* debugCorrVox = | ||
| new TNtuple("corrvox", "corrvox", "iRoc:iRow:n:x:y:z:vx:vy:vz:cx:cy:cz"); | ||
|
|
||
| debugCorrVox->SetMarkerStyle(8); | ||
| debugCorrVox->SetMarkerSize(0.8); | ||
| debugCorrVox->SetMarkerColor(kMagenta); | ||
|
|
There was a problem hiding this comment.
Why is this added? It indeed seems to be an exact copy of debugVox filled with the same entries below.
There was a problem hiding this comment.
The only reason is to have the tree in two different colors and marker sizes. One can then draw vx,vy, and vz in red color and cx,cy, and cz in magenta without much typing in the command line. One can put these values in different trees, but sometimes I want to see cx-vx, cy-vy etc.
|
Error while checking build/O2/fullCI for 71eac44 at 2024-05-25 00:33: Full log here. |
Co-authored-by: wiechula <11199190+wiechula@users.noreply.github.com>
|
@wiechula, I mark the PR draft again. Alexander Schmah sees some problems; It makes sense to fix them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains several commits:
non-uniform grid that corresponds to the track residual voxels
limits for SC correction values per TPC row
multithreaded reading of the residual tree
fix propagation of the track residual data to the TPC row edges
fix initialization of the track residuals in the test macro