Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation power for Pions and Electrons #12988

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

HorstMa
Copy link
Contributor

@HorstMa HorstMa commented Apr 5, 2024

This PR adds the separation power that can be trended for pions and electrons at the MIP point.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-mc
async-data

Detectors/TPC/qc/include/TPCQC/PID.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/include/TPCQC/PID.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/PID.cxx Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/PID.cxx Outdated Show resolved Hide resolved
@alibuild
Copy link
Collaborator

alibuild commented Apr 5, 2024

Error while checking build/O2/fullCI for cd14504 at 2024-04-05 13:02:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
input_line_9:168:48: error: use of undeclared identifier 'cSeparationPowerCanvas'
Error: /sw/slc8_x86-64/ROOT/v6-30-01-alice4-6/bin/rootcling: compilation failure (/sw/BUILD/4d6ee0878a064ffb56614948916ac517898352c7/O2/Detectors/TPC/qc/G__O2TPCQC927318bec8_dictUmbrella.h)
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for aeaa058 at 2024-04-18 22:26:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HorstMa please rebase your branch to fresh dev and force push.

Detectors/TPC/qc/include/TPCQC/PID.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/include/TPCQC/PID.h Outdated Show resolved Hide resolved
Detectors/TPC/qc/src/PID.cxx Outdated Show resolved Hide resolved
Formatting

Comments

clang format

naming Convention

Added Separation Power Plot for Pions and electrons

Comments

last changes
@alibuild
Copy link
Collaborator

alibuild commented May 22, 2024

Error while checking build/O2/fullCI for aa1c8f9 at 2024-05-25 04:44:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/c15687ac46472ba01de497628a4f78d9b0600da0/slc8_x86-64/o2checkcode/1.0-local3099/etc/modulefiles
++ cat
--

Full log here.

@shahor02 shahor02 merged commit bdf72dd into AliceO2Group:dev Jun 6, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants