-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getters for the MC mask #12667
base: dev
Are you sure you want to change the base?
Add getters for the MC mask #12667
Conversation
Error while checking build/O2/fullCI for 39dc105 at 2024-04-08 04:01:
Full log here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See my comments for consideration.
}); | ||
DECLARE_SOA_DYNAMIC_COLUMN(McMismatchInTPC, mcMismatchInTPC, //! Mismatch in the TPC | ||
[](uint16_t mcMask, int layer) -> bool { | ||
if (layer >= 10 || layer < 7) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these layers for the TPC? Shall we add an enum to DataTypes.h to make it more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njacazio What do you think?
Error while checking build/O2/fullCI for c2cbbb2 at 2024-06-01 18:18:
Full log here. |
No description provided.