[Feature] Network module: Network connected but no internet format #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absobel
changed the title
|
Hey, I saw that this pull request never had any comments or anything. Would it be possible to review my code and tell me if I need to modify it, or if it is an eldritch horror of an abomination, or anything in between ? I guess my pull request just went unnoticed x) (tbh i forgot it too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #1487.
It seem to work with wifi but I couldn't test it with ethernet because I lack an ethernet port on my laptop.
The network module will try pinging the list of servers in the array "ping-servers" (the module will keep its default behaviour if it is empty or not initialised) every "interval" seconds. I also added the format for WiFi without internet "format-wifi-no-internet" and the format for ethernet without internet "format-ethernet-no-internet" if the pings fail