Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for installing AdaptiveCpp on macbook Pro M1 #1437

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

adi-lb-phoenix
Copy link

Documentation for installing AdaptiveCpp on macbook Pro M1 with reference to #1433

adi-lb-phoenix and others added 4 commits April 15, 2024 12:40
Documentation steps followed to install AdaptiveCpp on Macbook Pro M1 with Apple chip , MacOS: Ventura 13.1
text changes made to the previous commit
@illuhad
Copy link
Collaborator

illuhad commented May 2, 2024

Thank you. Perhaps some of our users with Mac experience (@normallytangent ?) can comment on the documented steps.

It might be a good idea to also enable the SSCP compiler and document how to set things up with LLVM. The SSCP JIT compiler for host CPU I think should work on Mac.

At a higher level, I think the most important question is how this content would fit into the existing documentation. This PR just provides a text file that is referenced from nowhere, which makes it questionable whether it would be found by users. We could add some structure to cover different OS. Or, we do the same what we do currently with Windows and document the steps for Mac in a Wiki-page (https://github.com/AdaptiveCpp/AdaptiveCpp/wiki/Using-AdaptiveCpp-on-Windows).

@adi-lb-phoenix
Copy link
Author

adi-lb-phoenix commented May 10, 2024

@illuhad Thank you for the reply .
I think its better if documentation related to macOS can be replicated for how its done with windows as you suggested , because installing and running the application should not be cumbersome . Also the documentation related to macOS that's already existing was not complete enough . I will push the changes soon and keep you posted .
why do you suggest the idea "it might be a good idea to also enable the SSCP compiler " ?

@illuhad
Copy link
Collaborator

illuhad commented May 16, 2024

why do you suggest the idea "it might be a good idea to also enable the SSCP compiler " ?

Because the SSCP JIT compiler (--acpp-targets=generic) is our default and most powerful compiler. It can also target the host CPU and in principle it should be able to run on Mac. So ideally, we can verify that it works and then also recommend people to use it on Mac. We are already heavily pushing Linux users towards using the SSCP compiler.

We should first enable it in Ma CI though; @fodinabor recently tried this and discovered some hiccups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants