Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use device_selector in group_functions test #1369

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Use device_selector in group_functions test #1369

wants to merge 1 commit into from

Conversation

sbalint98
Copy link
Collaborator

No description provided.

illuhad
illuhad reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please separate the "dropping cl::" change? It's very difficult to see otherwise what exactly this PR changes w.r.t device selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illuhad illuhad illuhad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbalint98 @illuhad