Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Replace org.json and Gson with Jackson #19

Closed

Conversation

amohammedalfresco
Copy link
Contributor

@amohammedalfresco amohammedalfresco commented Mar 20, 2020

for Activiti/Activiti#3155

  • Initial commit for org.json replacement with jackson library

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2020

CLA assistant check
All committers have signed the CLA.

@amohammedalfresco amohammedalfresco self-assigned this Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #19 into develop will increase coverage by 2.32%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #19      +/-   ##
=============================================
+ Coverage      48.01%   50.33%   +2.32%     
+ Complexity       623      278     -345     
=============================================
  Files            620      495     -125     
  Lines          10460     7716    -2744     
  Branches         617      465     -152     
=============================================
- Hits            5022     3884    -1138     
+ Misses          5241     3700    -1541     
+ Partials         197      132      -65
Impacted Files Coverage Δ Complexity Δ
...ud/services/modeling/service/api/ModelService.java
...deling/rest/assembler/PagedModelTypeAssembler.java
.../ws/transport/AbstractGraphQLSubProtocolEvent.java
...ing/validation/process/BpmnModelNameValidator.java
.../datafetcher/EngineEventsPublisherDataFetcher.java
...s/BpmnModelServiceTaskImplementationValidator.java
...ql/events/transformer/EngineEventsTransformer.java
...s/modeling/converter/ConnectorActionParameter.java
...services/modeling/validation/DNSNameValidator.java
...criptions/GraphQLSubscriptionSchemaProperties.java
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829a69d...7f6e4c5. Read the comment docs.

@amohammedalfresco amohammedalfresco changed the title [WIP]: AAE-2016 - Replace org.json and Gson with Jackson AAE-2016 - Replace org.json and Gson with Jackson Mar 20, 2020
@amohammedalfresco amohammedalfresco changed the title AAE-2016 - Replace org.json and Gson with Jackson [WIP]: AAE-2016 - Replace org.json and Gson with Jackson Mar 20, 2020
@amohammedalfresco
Copy link
Contributor Author

I'm hitting a wall here due to everit-json-schema heavily using org.json in their module, and to my surprise I've found they too are performing a task to replace org.json with jackson in PR#190.

I believe it would be wise to may be wait for their latest version which already replace org.json to jackson and so in theory we have less worry to fix the problems in our code.

@@ -28,7 +28,8 @@
<activiti-cloud-acceptance-tests.version>${project.version}</activiti-cloud-acceptance-tests.version>
<activiti-cloud-modeling-service.version>${project.version}</activiti-cloud-modeling-service.version>
<everit-json-schema.version>1.12.1</everit-json-schema.version>
<json.version>20180813</json.version>
<jackson.version>2.10.2</jackson.version>
Copy link
Contributor

@mteodori mteodori Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions for jackson are not needed, they come from spring boot

@amohammedalfresco amohammedalfresco changed the title [WIP]: AAE-2016 - Replace org.json and Gson with Jackson [WIP]: Replace org.json and Gson with Jackson (Activiti/Activiti#3155) Mar 23, 2020
@mteodori mteodori changed the title [WIP]: Replace org.json and Gson with Jackson (Activiti/Activiti#3155) [WIP]: Replace org.json and Gson with Jackson Apr 27, 2020
@mteodori
Copy link
Contributor

closing as won't fix, the everit library has rejected the PR to move to Jackson

@mteodori mteodori closed this Apr 27, 2020
@mteodori mteodori deleted the AAE-2016-replace-json-gson-with-jackson branch April 27, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants