Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DEBUG_LIBSTDCXX option to GNU Make gcc for libstdc++ debug #3945

Merged
merged 3 commits into from
May 27, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 16, 2024

this catches bounds errors in the standard library containers

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

this catches bounds errors in the standard library containers
@zingale
Copy link
Member Author

zingale commented May 16, 2024

@zingale
Copy link
Member Author

zingale commented May 16, 2024

not sure if we need this as an option so I left it WIP. It doesn't find issues in Castro. I am not sure how much of the standard library containers we rely on.

@WeiqunZhang WeiqunZhang self-requested a review May 22, 2024 15:50
@WeiqunZhang WeiqunZhang self-assigned this May 22, 2024
@WeiqunZhang
Copy link
Member

Since the new option is opt-in, there is no harm I guess.

@WeiqunZhang WeiqunZhang changed the title [WIP] add DEBUG_LIBSTDCXX option to GNU Make gcc for libstdc++ debug add DEBUG_LIBSTDCXX option to GNU Make gcc for libstdc++ debug May 27, 2024
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) May 27, 2024 17:33
@WeiqunZhang WeiqunZhang merged commit 28b0101 into AMReX-Codes:development May 27, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants