docs: clarify func-style #18477
Merged
docs: clarify func-style #18477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nzakas
requested changes
May 20, 2024
camsteffen
force-pushed
the
func-style-docs
branch
from
5392220
to
ec2985c
Compare
|
Hi @camsteffen, requested changes are yet to be implemented, can you implement them? |
camsteffen
force-pushed
the
func-style-docs
branch
from
ec2985c
to
d617915
Compare
|
facepalm I'm sorry, I had the changes locally but didn't actually push them up. |
mdjermanovic
previously requested changes
May 25, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
nzakas
approved these changes
May 27, 2024
There was a problem hiding this comment.
LGTM. I applied @mdjermanovic's suggestion, so this is good to go. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
constovervarin examplesIs there anything you'd like reviewers to focus on?
Fixes: #18474