-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgccjit: add RPATH reference on Intel macOS #171811
Conversation
8466f8a
to
55543e2
Compare
71b3180
to
3192c6e
Compare
Linux is failing because it can't find the zlib headers. Maybe related to the removal of zlib from the Docker container? CC @Bo98 |
Looks like this has never been using Homebrew zlib properly then 🙂 Upstream zlib detection doesn't look like it's very good: https://github.com/gcc-mirror/gcc/blob/releases/gcc-14.1.0/config/zlib.m4. So sounds like we have to pass CFLAGS ourselves, unlike every other dependency where we can pass it properly as an option. |
Fixes Homebrew/discussions#5364. Also, update the test to avoid breaking this again.
Note: there is an alternative approach at #171822. |
Thanks @carlocab |
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Fixes Homebrew/discussions#5364.
Also, update the test to avoid breaking this again.