Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned removal of crucial DOM events #56

Open
partiid opened this issue Aug 23, 2023 · 3 comments
Open

Planned removal of crucial DOM events #56

partiid opened this issue Aug 23, 2023 · 3 comments

Comments

@partiid
Copy link

partiid commented Aug 23, 2023

Hello, lighthouse detects this library as depracated due to planned removal of some DOMevents:

DOM Mutation Events, including DOMSubtreeModified, DOMNodeInserted, DOMNodeRemoved, DOMNodeRemovedFromDocument, DOMNodeInsertedIntoDocument, and DOMCharacterDataModified are deprecated (https://w3c.github.io/uievents/#legacy-event-types) and will be removed. Please use MutationObserver instead.

The library is great, are you planning to migrate to MutationObservers instead? I think it would be worth giving it a try.

@FRSgit
Copy link
Collaborator

FRSgit commented Aug 25, 2023

Hey @partiid!

Could you elaborate a bit more about the problem?
In this library none of DOM* events are used. Also - MutationObserver shouldn't be needed in the implementation either.

@therampagerado
Copy link

image

@partiid
Copy link
Author

partiid commented Apr 9, 2024

Hello, sorry for not replying. The screen above says it all. If noone of them are used, why lighthouse detects it as deprecated API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants