-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize rerendering of recent conversations for single message events. #23638
Comments
@zulipbot add "help wanted" |
Hi @laurynmm , this issue looks really interesting so I started digging around :). So currently, as far as my understanding goes when the messages are being fetched for the first time to complete-rerender being called, this is the callstack: and this is the callstack when a message comes in from the events api: And it seems like complete_rerender is being called indiscriminately in the process_messages function. I think at the "insert_new_messages" function, I'm thinking a simple conditional and a new function "update_message" in recent_topics_ui.js can solve the problem. Does this approach sound reasonabe to you? I would really appreciate the feedback. |
@cledi01 - I think it'd be good to look at the code paths that call |
Hi, I am a student at Carnegie Mellon working on a group project for my Foundations of Software Engineering class. Is it ok if my group helps out with this issue for our project? |
@zulipbot claim |
@dartaylor8 We don't have any special rules for class projects. Your group should follow the general guidelines for all contributors. https://zulip.readthedocs.io/en/latest/overview/contributing.html Have fun! |
@laurynmm I am working on a solution and was trying to look into inplace_rerender. Do you happen to know what exactly this function's intended purpose is? Thanks! |
@ilaiyengar - I would look at the places that |
Thanks so much! I will look into this. |
@ilaiyengar You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@zulipbot claim. |
@Ujjawal3 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@zulipbot claim |
Currently, when new messages are received (either via the events API or fetching messages), the Recent conversations view will do a
complete_rerender
if any of the processed messages has data that has been updated/added to the view.Instead of completely rerendering when processing a single message (most likely from the events API), it would preferable to optimize so that we only update the conversation that was updated for the new message data when/if possible.
Follow-up issue from #23603 and #23617.
@zulipbot add "area: recent-conversations"
The text was updated successfully, but these errors were encountered: