-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve onboarding_steps
subystem.
#30043
Labels
Comments
Hello @zulip/server-onboarding members, this issue was labeled with the "area: onboarding" label, so you may want to check it out! |
prakhar1144
added a commit
to prakhar1144/zulip
that referenced
this issue
May 27, 2024
The 'tutorial_status' field on 'UserProfile' model is no longer used to show onboarding tutorial. This commit removes the 'tutorial_status' field and 'needs_tutorial' parameter in 'page_params'. Fixes part of zulip#30043.
12 tasks
prakhar1144
added a commit
to prakhar1144/zulip
that referenced
this issue
May 27, 2024
The 'tutorial_status' field on 'UserProfile' model is no longer used to show onboarding tutorial. This commit removes the 'tutorial_status' field and 'needs_tutorial' parameter in 'page_params'. Fixes part of zulip#30043.
prakhar1144
added a commit
to prakhar1144/zulip
that referenced
this issue
May 29, 2024
Removes the 'onboarding_steps' field on 'UserProfile' model which is no longer used. It was introduced back in 2013 (b5e22bf), and is no longer used. Fixes part of zulip#30043.
12 tasks
prakhar1144
added a commit
to prakhar1144/zulip
that referenced
this issue
Jun 3, 2024
Earlier, onboarding_steps field of state_data was stored as current_user_params. Now, we store it separately in a data structure initialized in onboarding_steps.ts Reason: All the other state_data fields stored in current_user_params are attributes of UserProfile. So, it makes sense to store it separately. Fixes part of zulip#30043.
timabbott
pushed a commit
that referenced
this issue
Jun 3, 2024
Earlier, onboarding_steps field of state_data was stored as current_user_params. Now, we store it separately in a data structure initialized in onboarding_steps.ts Reason: All the other state_data fields stored in current_user_params are attributes of UserProfile. So, it makes sense to store it separately. Fixes part of #30043.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-ups of #29296 & improvements for
onboarding_steps
subsystem as a whole:test_hotspots.py
totest_onboarding_steps.py
tutorial_status
field fromUserProfile
model. -- Fields is no longer used.onboarding_steps
field fromUserProfile
model. -- Fields is no longer used. (b5e22bf)ui_init.js
to not storeonboarding_steps
state data ascurrent_user_params
entry & related changes.The text was updated successfully, but these errors were encountered: