[UI] Coinjoin Settings page suggestions

[yahiheb]

Some suggestions to improve the UI/UX of this page:

• The discoverability of the new feature Coinjoin To Another Wallet is bad. Just by looking at the UI it is not intuitive the feature exits. Maybe replace Output Wallet by Coinjoin to this wallet which is more clear.
• Misalignment of the Change button.
• Add some vertical separation between each setting/feature.
• All the settings are placed on the top left corner of the page while the rest is completely empty which is ugly.

Edit (more suggestions):

• We should disable or even better hide the threshold setting if the auto-start is disabled.
• Changes to Auto-start setting apply immediately regardless if you click the Done button which is not consistent with the other dialogs like the coinjoin strategy and coinjoin strategy settings

[Kruwed]

* The discoverability of the new feature `Coinjoin To Another Wallet` is bad. Just by looking at the UI it is not intuitive the feature exits. Maybe replace `Output Wallet` by `Coinjoin to this wallet` which is more clear.

How about Destination Wallet ?

[collins-okafor]

* The discoverability of the new feature `Coinjoin To Another Wallet` is bad. Just by looking at the UI it is not intuitive the feature exits. Maybe replace `Output Wallet` by `Coinjoin to this wallet` which is more clear.

How about Destination Wallet ?

Are we going with this?

[soosr]

Edit (more suggestions):

• We should disable or even better hide the threshold setting if the auto-start is disabled.

They are not related. #13067 (comment)

• Changes to Auto-start setting apply immediately regardless if you click the Done button which is not consistent with the other dialogs like the coinjoin strategy and coinjoin strategy settings

It is applied regardless of clicking Done. It just takes 1 second to do, which is the prevention for unwanted savings during the user types. If they don't type for 1 second, it will save it.

https://github.com/zkSNACKs/WalletWasabi/blob/ede4ac5f208a8be0ab99bfd17aedd4617b746e18/WalletWasabi.Fluent/ViewModels/Wallets/Settings/WalletCoinJoinSettingsViewModel.cs#L79-L91

[yahiheb]

It is applied regardless of clicking Done.

Yes, but that's the problem. For the other dialogs you need to click the Done button to save your changes, this is not the case here.

[soosr]

It is applied regardless of clicking Done.

Yes, but that's the problem. For the other dialogs you need to click the Done button to save your changes, this is not the case here.

What do you mean? General, Bitcoin, Advanced, Wallet General, Wallet Coinjoin. Whenever you change something it has an immediate effect.
Except for the Coinjoin strategy dialog.

[yahiheb]

I am talking about the dialogs: Wallet Settings, Coinjoin Strategy, and Coinjoin Strategy Settings.
Clicking Done is not required on the Wallet Settings dialog for changes to be saved, while it is on the other two.