Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync Wallet Button #2005

Open
benthecarman opened this issue Jul 24, 2019 · 12 comments · May be fixed by #12959
Open

Resync Wallet Button #2005

benthecarman opened this issue Jul 24, 2019 · 12 comments · May be fixed by #12959
Assignees
Milestone

Comments

@benthecarman
Copy link
Contributor

benthecarman commented Jul 24, 2019

Is your feature request related to a problem? Please describe.

It seems for some wallet errors the best way is to have the wallet resync. Currently the user needs to delete some files to do this, this generally a bad way to handle this as the user could accidentally delete something they are not supposed to.

Describe the solution you'd like

A button that resyncs wallet, probably by deleting the necessary files for the user.

Describe alternatives you've considered

The button could also mark as "Needs to Resync" and on startup do a resync without needing to delete the blocks and filters it already has downloaded.

@MaxHillebrand
Copy link
Collaborator

Yeah, this makes sense.

But where to put the button, and how does the user know that he needs to resync?

Is this maybe more of a peer support feature - so that one can easily say "Click on Wallet resync and it should be fixed" without explaining the details. That would already help a lot.

And if maybe the wallet can automatically detect that something is wrong, and then give a message that the user should resync, that might be even better!

@benthecarman
Copy link
Contributor Author

I was thinking that the button would be in the wallet info page, wallet manager, or the top toolbar.

@MaxHillebrand
Copy link
Collaborator

Probably Wallet Manager is a good place to put it.

@MaxHillebrand
Copy link
Collaborator

Would still be useful.

@soosr
Copy link
Collaborator

soosr commented Aug 19, 2022

AFAIK everyone is against this because we should rather fix the bug the resync to be needed.

@yahiheb
Copy link
Collaborator

yahiheb commented May 4, 2023

In many cases the users wallet is not properly synced and the balance or the status of their transactions is wrong and a resync of the wallet is the only solution. #10616

This is definitely a useful feature to have.

@turbolay
Copy link
Collaborator

turbolay commented May 4, 2023

Furthermore, after turbosync we will have 2 different heights, it will be even more confusing for the user.
Please note that cases where a resync is needed should be more rare than we think, and most of cases resync is probably not the real solution of user's problems.

@Kruwed
Copy link
Collaborator

Kruwed commented May 4, 2023

UI wise, the "advanced" settings menu seems like the appropriate place to put this, there's plenty of extra room:

image

@Pule08
Copy link
Collaborator

Pule08 commented May 8, 2023

  1. code team implement the logic
  2. UI team finish the ui part.

@lontivero lontivero reopened this Jun 21, 2023
@Kruwed
Copy link
Collaborator

Kruwed commented Aug 13, 2023

A coinjoin transaction being replaced and confirmed leads to the wallet balance being incorrect. This should be prioritized to simplify the recovery process for users whose wallets become broken due to this unavoidable circumstance.

@yahiheb
Copy link
Collaborator

yahiheb commented Feb 12, 2024

This is a good to have for the v2.0.7 release.

@yahiheb yahiheb added the UX label Feb 12, 2024
@yahiheb yahiheb added this to the v2.0.7 milestone Feb 12, 2024
@molnard
Copy link
Collaborator

molnard commented Feb 24, 2024

This is a good to have for the v2.0.7 release.

ACK

@MaxHillebrand MaxHillebrand modified the milestones: v2.0.7, v2.0.8 Apr 16, 2024
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment