std: implement BoundedArray.addManyAsSlice #19962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjb3d
force-pushed
the
bounded_array_add_slice
branch
from
11cc981
to
1e6d7f3
Compare
sjb3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
BoundedArray.addManyAsSlice, for parity withArrayList.addManyAsSlice.I noticed this API was missing when switching a buffer from
ArrayListtoBoundedArraysince a small fixed size buffer was enough for my use case, and avoided an allocation. I think it would be useful for these two containers to share the same methods where possible, so that users of the standard library can make this kind of switch easily.The PR also has a doc comment fix for
BoundedArray.addManyAsArray, since it returns a pointer to an array, not a slice.Closes #19967.