Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: when std.options.crypto_always_getrandom is set, use std.option.cryptoRandomSeed #19965

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bugfix: when std.options.crypto_always_getrandom is set, use std.option.cryptoRandomSeed #19965

wants to merge 3 commits into from

Conversation

SkamDart
Copy link

Resolves #19943

@SkamDart
Copy link
Author

I am trying to figure out how to write a test for this in-tree. Any guidance would be appreciated.

@Vexu
Copy link
Member

Vexu commented May 21, 2024

I don't think something like this necessarily needs a test.

@SkamDart SkamDart marked this pull request as ready for review May 21, 2024 20:09
@SkamDart
Copy link
Author

SkamDart commented May 21, 2024 •
edited

I don't think something like this necessarily needs a test.

@Vexu Thank you for the review. I have switched the PR to open to test the changes in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std.options.crypto_always_getrandom ignores overridden std.options.cryptoRandomSeed
2 participants
@SkamDart @Vexu