Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit type conversions in header files #72974

Closed
trampas opened this issue May 18, 2024 · 2 comments
Closed

Implicit type conversions in header files #72974

trampas opened this issue May 18, 2024 · 2 comments
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@trampas
Copy link

trampas commented May 18, 2024

When changing my compiler flags to include -Wconversion many of the zephyr headers are flawed as having questionable type conversions. This include atomic.h as well a several other headers.

I have not found a good way to work around this problem. If I fix the headers locally they will not propagate to next clean build. I can try disabling warnings in source code but have to do that for every include from zephyr, which is not clean or easy.

I could do a fix for headers pull request but we are locked into older zephyr version. Additionally there is risk I would create more bugs than I fix in the process or mask bugs.

It is kind of a shame on zephyr not to require no implicit type conversions on the project, as these conversations are often laten bugs.

@trampas trampas added the bug The issue is a bug, or the PR is fixing a bug label May 18, 2024
Copy link

Hi @trampas! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@nashif
Copy link
Member

nashif commented May 21, 2024

This duplicates #72488

@nashif nashif closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

2 participants