boards: st: vbat
node enabled without enabling associated adc
node
#72914
Labels
bug
The issue is a bug, or the PR is fixing a bug
Good first issue
Good for a first time contributor to take
platform: STM32
ST Micro STM32
priority: low
Low impact/importance bug
Describe the bug
The ST vbat driver expects the
adc
node to be enabled in the devicetree (due to the usage ofDEVICE_DT_GET
), but thevbat
nodes in multiple boards are currently being enabled without also enabling its associatedadc
nodezephyr/drivers/sensor/st/stm32_vbat/stm32_vbat.c
Lines 119 to 123 in adeb19b
this causes compilation to fail when vbat driver met its Kconfig conditions to build
zephyr/drivers/sensor/st/stm32_vbat/Kconfig
Lines 6 to 13 in adeb19b
To Reproduce
Steps to reproduce the behavior:
west build -b nucleo_h753zi -p auto zephyr/samples/sensor/sensor_shell
Expected behavior
vbat
probably shouldn't be enabled if theadc
that it is using isn't enabledImpact
Causing CI to fail in #72833
Logs and console output
See 72910
Environment (please complete the following information):
main
branchAdditional context
The proposed fix in #72911 only fixes the driver side of the issues, the
vbat
nodes are still being enabled in boards where it shouldntThe text was updated successfully, but these errors were encountered: