Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: display labels [camera capture] [upload image] ABOVE canvas #1

Open
stewie opened this issue Sep 6, 2014 · 2 comments
Open

Comments

@stewie
Copy link

stewie commented Sep 6, 2014

With firefox extension "Image Zoom" installed, it's interesting to scrollzoom to enlarge the canvas and watch while the drawing progresses, but... currently, the [camera capture] [upload image] labels are displayed to a fixed(?) location. The text, in that fixed location, winds up overlaying the zoomed canvas element.

When the page loads, the dashed border around the canvas invites user to drag an image. I'm suggesting: Initial size of the canvas element could be a bit smaller with the [camera capture] [upload image] link labels placed at the top.

Also, once the painting begins, those [camera capture] [upload image] links become disabled, yes? (Cannot upload a different image unless the page is refreshed, yes? Asking because I might just be facing a limitation/quirk specific to my browser/version.) If the links are, in fact, disabled once painting begins... it would make sense to toggle their DOM elements hidden when painting commences.

@zden
Copy link
Owner

zden commented Sep 10, 2014

First of all, a dropped image should work on desktop computers always! No matter you are in the painting process.
The same applies for upload image what is created for mobile users.
If this happens on the desktop check the web console for possible error messages.
In the case of badly aligned [camera capture] [upload image], please provide a screenshot. Oh OK I'll try page zoom in browsers and try to see for myself too.
Page was tested on win/osx systems and with firefox/chrome/safari browsers. But haven't tested much under browser-zoom feature so please write down your configuration if you can.
Thanks, Stewie for all valuable thoughts and reports. Much appreciated.

@stewie
Copy link
Author

stewie commented Sep 10, 2014

To clarify/justify my suggestion to "display labels [camera capture] [upload image] ABOVE canvas", here's a screencap to illustrate the "fixed css positioning vs zoom" issue I'm wrestling with:
http://i.imgur.com/B1FzSW6.jpg

I don't have a webcam, so can't test that control but, yes, since posting earlier, I've discovered that the app continually accepts a dropped image event, even while drawing is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants