Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in Single Page Application (SPA) #8434

Open
1 task
gabbsmo opened this issue Apr 8, 2024 · 6 comments
Open
1 task

False positive in Single Page Application (SPA) #8434

gabbsmo opened this issue Apr 8, 2024 · 6 comments

Comments

@gabbsmo
Copy link

gabbsmo commented Apr 8, 2024

Describe the bug

I ran ZAP and got a warning "Hidden file found https://app.metashare.com/BitKeeper". Indeed, there is no BitKeeper file in wwwroot, but a GET request to this URL will return our index.html. All server side routes resolve to index.html since we rely on client side routing for the app. I believe this is a common pattern in modern web apps.

Steps to reproduce the behavior

Run the automated scan with classic spider.

Expected behavior

Perhaps https://host/BitKeeper should not be considered as a hidden file, if the response body is equal to that of https://host/.

Software versions

2.14.0

Screenshots

hidden_file

Errors from the zap.log file

No response

Additional context

Also logged this issue with snallygaster

Would you like to help fix this issue?

  • Yes
@kingthorin
Copy link
Member

kingthorin commented Apr 8, 2024

FYI ZAP is no longer an OWASP project.

@kingthorin
Copy link
Member

Also you didn't run snallyghaster or do anything related to the classic spider. Those alerts are raised by the Hidden File Finder active scan rule which was originally inspired by and drew some patterns/targets from snallyghaster. (You should close your upstream issue, it isn't relevant to them.)

@gabbsmo
Copy link
Author

gabbsmo commented Apr 8, 2024

Thanks. I have closed the upstream issue and updated this bug description based on your feedback.

@kingthorin
Copy link
Member

@gabbsmo can you clarify the behavior so that I ensure I fix it properly. Is there a redirect or does any unmatched request simply display the default site content?

@gabbsmo
Copy link
Author

gabbsmo commented Apr 27, 2024

@kingthorin unmatched requests show default contents. No redirects.

@kingthorin
Copy link
Member

Thanks. I think I've got a plan to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants