Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin client more configurable #99

Open
jclementemis opened this issue Jan 27, 2023 · 1 comment
Open

Make admin client more configurable #99

jclementemis opened this issue Jan 27, 2023 · 1 comment

Comments

@jclementemis
Copy link

jclementemis commented Jan 27, 2023

As user
I want to configure admin client via environment variables
So that I can change remoras behaviour at runtime

Description

Currently I believe that it is not possible to add additional properties to admin client via environment variables.
https://github.com/zalando-incubator/remora/blob/master/src/main/resources/application.conf#L24

How I would like to use this feature ?

  • I run remora in a kubernetes environment and I want to connect remora to AWS MSK instance that has SSL enabled between client and broker. I would like to supply SSL security.protocol to the admin client via kubernetes environment variable or configMaps.

Acceptance criteria

  • A user should be able to configure properties of the admin-client e.g security.protocol via environment variables
@soceanainn
Copy link
Contributor

There are a lot of potential configuration options for configuring the admin-client properties, and it would be a lot of work to maintain the ability to set any of them as environment variables (which also has additional challenges when handling nested structured date). We added the ability to configure admin-client properties specifically for the use case you are describing but made the conscious decision not to support doing this using env variables.

You can overwrite the configuration file by storing an inline conf file in a Kubernetes configmap, and then mounting that as a file to your pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants