Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): update workflows #1086

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

chore(ci): update workflows #1086

wants to merge 26 commits into from

Conversation

nonperforming
Copy link
Contributor

@nonperforming nonperforming commented May 7, 2023 •
edited

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Update: Node12 has been removed and will now run on Node16 https://github.blog/changelog/2023-07-17-github-actions-removal-of-node12-from-the-actions-runner/

CMake Build is no longer being updated so I made Actions directly invoke CMake from shell

Edit: Fixes #1047

@nonperforming nonperforming changed the title chore(ci): update cache and install-nix chore(ci): update workflows May 7, 2023
yvt
yvt reviewed May 9, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nonperforming @yvt
Source directory in workspace/openspades
9393a29 
Co-authored-by: yvt <i@yvt.jp>
nonperforming and others added 2 commits May 15, 2023 18:46
@nonperforming @yvt
Use bash
5e0013a 
Co-authored-by: yvt <i@yvt.jp>
@nonperforming
Fix macOS path
8e4e151
yvt
yvt reviewed May 15, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nonperforming
Copy link
Contributor Author

nonperforming commented May 16, 2023 •
edited

Windows:
SDL 2.0 not found, set ENV{SDL2DIR} to point to SDL 2.0

Which is strange because we have
sdl2:x86-windows-static
included in vcpkg_x86-windows.txt

Mac:
Ninja not found?
Running cmake -G in my console produces
...
Ninja = Generates build.ninja files.
...
And Ninja tool is installed by default in macOS runners??

@yvt
Copy link
Owner

yvt commented May 16, 2023

Windows: SDL 2.0 not found, set ENV{SDL2DIR} to point to SDL 2.0

Which is strange because we have sdl2:x86-windows-static included in vcpkg_x86-windows.txt

Could you remove shell: bash and try again?

The backtick character for line continuation is specific to PowerShell. PowerShell uses it in place of the backslash symbol to avoid issues with Windows paths. And apparently ${{ runner.workspace }} includes backslashes.

@nonperforming
Copy link
Contributor Author

nonperforming commented May 18, 2023 •
edited

And Ninja tool is installed by default in macOS runners??

I was mistaking AppVeyor for GitHub Actions here. GHA does not package Ninja with their runners

https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md

@nonperforming
Copy link
Contributor Author

Windows seems to work now!

@nonperforming
Copy link
Contributor Author

macOS incorrectly succeeding

@nonperforming
Copy link
Contributor Author

Everything seems to be fine...

@nonperforming nonperforming requested a review from yvt July 20, 2023 06:31
@nonperforming nonperforming marked this pull request as ready for review July 20, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvt yvt Awaiting requested review from yvt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows/macOS CI broken
2 participants
@nonperforming @yvt