BUG: avoid ResourceWarnings in the amrex frontend #4891
Merged
+45
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
previously approved these changes
May 1, 2024
matthewturk
previously approved these changes
May 1, 2024
2 tasks
neutrinoceros
changed the title
Use context managers where the line length allows, and manually close all other files that are opened outside a `with` statement. Fixes yt-project#4890.
yut23
force-pushed
the
fix-boxlib-resourcewarnings
branch
from
a8d6f31
to
accaf59
Compare
yut23
changed the title
neutrinoceros
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Use context managers where the line length allows, and manually close all other files that are opened outside a
withstatement.Fixes #4890.