Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmask with the same size of the data is a bad design #71

Open
zhenchen16 opened this issue May 7, 2021 · 0 comments
Open

fmask with the same size of the data is a bad design #71

zhenchen16 opened this issue May 7, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@zhenchen16
Copy link
Collaborator

the matrix for storing bad pixels, fmask is always the same size as all the diffraction patterns, 3D. For data as large as 256^4, the fmask can use memory (GPU!) up to 16 GB! For most of the data, fmask may not change for different diffraction, then fmask should only be a single 2D matrix instead of 3D. Even if fmask is pattern dependent, bad pixels are only a small fraction. Using the indexes of bad pixels instead of a 3D matrix with many ones can save a lot of memory.

@zhenchen16 zhenchen16 added bug Something isn't working enhancement New feature or request labels May 7, 2021
@yijiang1 yijiang1 removed the bug Something isn't working label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants