Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Client: Post with content receiver #1818

Open
Green-Sky opened this issue Apr 17, 2024 · 3 comments
Open

Feature request: Client: Post with content receiver #1818

Green-Sky opened this issue Apr 17, 2024 · 3 comments

Comments

@Green-Sky
Copy link

Green-Sky commented Apr 17, 2024

I have a usecase where client.Post() is called with a small body and the server response is a very lengthy string/json, where a content receiver would make sense.

And after all the difference between http GET PUT POST etc on the protocol level is just that, a word. 😏

@yhirose
Copy link
Owner

yhirose commented Apr 21, 2024

@Green-Sky thanks for the feedback. I didn't implement those because I simply don't need those. I don't expect any large response body when issuing any HTTP requests in my use cases except GET requests...

You can easily add such a POST method. Could you send a pull request to implement the method that you need with a unit test? Then, I'll review and merge it. Thanks!

@jmont-dev
Copy link

@Green-Sky I definitely have interest in this feature as well; if you roll a PR let me know otherwise I'll take a stab at it myself. Thanks.

@Green-Sky
Copy link
Author

@jmont-dev feel free to implement it, i am currently occupied with something else.
Tag me when you have something to test/review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants