Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization with first day of week different from Sunday is broken #55

Open
flo-l opened this issue Mar 11, 2020 · 3 comments
Open

Localization with first day of week different from Sunday is broken #55

flo-l opened this issue Mar 11, 2020 · 3 comments

Comments

@flo-l
Copy link
Contributor

flo-l commented Mar 11, 2020

Describe the bug
If a locale does specify a differen first day of the week than sunday, the calendar is showing wrong date/weekday combinations.

To Reproduce
Steps to reproduce the behavior:

  1. use a locale that sets a different weekday than sunday as first day of the week, eg. en-GB.
  2. look at the calendar and check if date and weekday match

Expected behavior
The grid of days should be shifted, such that eg. mondays are in the first column.

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux & Windows
  • Browser Chrome & Firefox
  • Version any

Smartphone (please complete the following information):

  • Device: Android
  • OS: any
  • Browser stock & firefox
  • Version any

Additional context
I introduced this bug with #46 . I'll try and fix it as soon as I have time.

@stepanfichtner
Copy link

Hi, it's some progress in this issue?

I'm currently solving the localization for cs and I'm solving exactly this problem that the date doesn't match the day of the week

Thank you

Stepan

@jkasperkiewicz
Copy link

Any update on this issue?

Best Regards
Jakub

@joakimcarlsten
Copy link

What did you end up going with? We're having this same issue atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants