Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More modular scss files #10

Open
danielr18 opened this issue Feb 24, 2019 · 0 comments
Open

More modular scss files #10

danielr18 opened this issue Feb 24, 2019 · 0 comments
Assignees

Comments

@danielr18
Copy link

Is your feature request related to a problem? Please describe.
Describe alternatives you've considered
I wouldn't like to have to duplicate all the app.scss code to just delete the Lato font import, or if I have light/dark themes in the site, having to either import the complete app.scss under different selectors or duplicate the rules related to colors (which would lead to having to keep a look on styles updates if you update the component)

Describe the solution you'd like
If app.scss is split in 2 files: non theming related and theme related, you could have multiple themes with less css output, and without needing to duplicate the stylesheet (leading to easier upgrades later on). The default font family could be set in the default scss file like calendar.scss, but not in the modular files, to avoid downloading a font you might not want to use.

@y0c y0c self-assigned this Mar 1, 2019
@y0c y0c added this to the v0.3.6 milestone Mar 10, 2019
@y0c y0c modified the milestones: v0.3.6, v1.0.0 Mar 18, 2019
@y0c y0c removed this from the v1.0.0 milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants