Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xterm.onResize cannot receive correct data #5053

Closed
TheBlindM opened this issue May 9, 2024 · 4 comments
Closed

Xterm.onResize cannot receive correct data #5053

TheBlindM opened this issue May 9, 2024 · 4 comments

Comments

@TheBlindM
Copy link

TheBlindM commented May 9, 2024

After calling fitAddon. fit(), the cols and rows received by "xterm. onResize" were not accurate. When I modified the window size and triggered fitAddon. fit() again, it worked fine

QQ.20240509192949.mp4

Before modifying window size:
image

After modifying the window size
image

Details

  • Browser and browser version: WebView2: 124.0.2478.80
  • OS version: win10
  • xterm.js version: 5.3.0
@tisilent
Copy link
Contributor

It doesn't feel like it's a addon-fit issue.
Print xterm.rows xterm.cols

@TheBlindM
Copy link
Author

TheBlindM commented May 11, 2024

It doesn't feel like it's a addon-fit issue. Print xterm.rows xterm.cols

image

This type of offline only appears when the page is first accessed

@tisilent
Copy link
Contributor

When executing fit(), the size of the parent element?
Figure 1, it seems to be forcibly stretched.

@TheBlindM
Copy link
Author

When executing fit(), the size of the parent element? Figure 1, it seems to be forcibly stretched.

The parent elements are all saturated, with normal width and height, but the onResize value is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants