-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support callback on scrollLines #4842
Comments
xterm.js/src/common/services/BufferService.ts Lines 128 to 150 in f6c4aee
It will update |
My case seems to be an edge case. When the i.e. at the top of the viewport. I tried doing the same thing when |
I tried to implement cursor based navigation.
When trying to handle CursorUp at the top of the buffer when there are scroll (i.e.
buffer.active.viewportY
andbuffer.active.baseY
> 0), I tried to do:But that doesn't work probably becuase
buffer.active.Y
is already 0.Or maybe
scrollLines()
didn't update thebuffer.active.viewportY/baseY
(I saw that they remain unchanged after the scroll happens.The text was updated successfully, but these errors were encountered: