Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong kernel in guassian blur ? #25

Open
tavihalperin opened this issue Nov 21, 2022 · 2 comments
Open

wrong kernel in guassian blur ? #25

tavihalperin opened this issue Nov 21, 2022 · 2 comments

Comments

@tavihalperin
Copy link

Hi,

you use twice gaussian blur with the same (101,101) kernel
should it be split into two 101x1 and 1x101 kernels?

or is it just a duplicate?

mask = cv2.GaussianBlur(mask, (101, 101), 11)

@woctezuma
Copy link
Contributor

woctezuma commented Nov 21, 2022

Nicely spotted. I cannot answer.

Just to be clear for xinntao, the issue is about the duplicate lines:

# blur the mask
mask = cv2.GaussianBlur(mask, (101, 101), 11)
mask = cv2.GaussianBlur(mask, (101, 101), 11)


Edit: This was added with ParseNet. I see it is used as well with GPEN.

@tavihalperin
Copy link
Author

Thanks for the pointer, I'll post it there as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants