Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move transform dimension check to top level API + more useful error messsage #633

Open
jbusecke opened this issue May 3, 2024 · 0 comments

Comments

@jbusecke
Copy link
Contributor

jbusecke commented May 3, 2024

I am just refamiliarizing myself with the transport API and just ran into an error caused by improper dimensionality for a conservative depth to depth regridding. The error is raised here but the nomenclature (phi, theta) will not be helpful to a user.
I propose we move this sort of check out of the algorithms to the top level API here.

This should raise an error that mentions the input variables along the lines of "when using method='conservative' your target input needs to be ...."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant