Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add align? #449

Open
dcherian opened this issue Jun 6, 2023 · 1 comment
Open

add align? #449

dcherian opened this issue Jun 6, 2023 · 1 comment
Labels
opinion wanted User input requested

Comments

@dcherian
Copy link
Contributor

dcherian commented Jun 6, 2023

xarray.align only supports an opt-out exclude kwarg, but for these purposes it seems like we'd want an opt-in include kwarg, so that we only aligned along specific user-specified dimensions (so cfxr.align(..., include="vertical")) Or perhaps cfxr.align_along_dims(..., dims="vertical")

xref Unidata/MetPy#1599 (comment)

I imagine a xarray Dataset going in that contains the variables needing to be unified, which will have multiple vertical coordinates (e.g., 'isobaric', 'isobaric3', 'isobaric5', etc.) and out comes a xarray Dataset with all of the same variables subset to the common levels that are available for all of the variables with a single common vertical coordinate name across all of the variables (e.g., 'isobaric_unified').

@dcherian
Copy link
Contributor Author

dcherian commented Jun 8, 2023

Given that renaming to a common dimension name is probably sensible, I lean towards align_along_dims to make it clear that this new function isn't too closely related to xr.align

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion wanted User input requested
Projects
None yet
Development

No branches or pull requests

1 participant