Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a mechanism in PredefinedValues to allow handle separator string values #645

Closed
wants to merge 1 commit into from

Conversation

netonjm
Copy link
Contributor

@netonjm netonjm commented Oct 3, 2019

In VS4Mac we have some PredefinedValues that include dividers to make more clear the selection of items for the user.

image

This is how it feels now.

image

Fixes #644

@netonjm netonjm self-assigned this Oct 3, 2019
@netonjm netonjm requested a review from ermau October 3, 2019 14:48
@netonjm
Copy link
Contributor Author

netonjm commented Oct 3, 2019

@ermau what do you think? (btw I didn't include windows changes implementing the interface)

@CartBlanche
Copy link
Contributor

@netonjm FYI - You can set PRs as Draft now and that way they can't be merged until you change them to normal PRs. That way you don't need the "do no merge" tag.

@ermau
Copy link
Member

ermau commented Oct 3, 2019

Probably going to have to do something like this for iOS, so we might need something a little more robust.

@ermau ermau closed this Oct 3, 2019
@netonjm netonjm deleted the separator-string branch October 3, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a mechanism to include separators in PredefinedValues
3 participants