Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mac] Initial Origin Control implementation #628

Closed
wants to merge 2 commits into from
Closed

[Mac] Initial Origin Control implementation #628

wants to merge 2 commits into from

Conversation

CartBlanche
Copy link
Contributor

@CartBlanche CartBlanche commented Sep 7, 2019 •
edited

Fixes #626

Dark:
Screen Shot 2019-09-07 at 13 23 16

Light:
Screen Shot 2019-09-07 at 13 23 34

@CartBlanche CartBlanche self-assigned this Sep 7, 2019
@CartBlanche
Copy link
Contributor Author

@ermau Could you have an cursory look over this draft, before I get too deep, and let me know if this is what you had in mind, or am I off piste??

@CartBlanche CartBlanche force-pushed the dominique-OriginControl branch 5 times, most recently from 39626fd to 5c4e128 Compare September 10, 2019 10:21
@CartBlanche
Copy link
Contributor Author

CartBlanche commented Sep 10, 2019 •
edited

@chkn & @viniciusjarina Could you please look over this OriginChanged code for the ported proppy control...
ccd06c2#diff-47e8ae53a308da0f8dc10c76a7a5effeR195-R212

I've tried to remove any external helper dependencies (for now, we may need to add it back in if more iOS controls need them), so just need another pair of eyes to make sure I've not missed something.

I was also thinking that we may need a property like DesignerFrame of type RectangeF (perhaps) in the IOrigin interface so that the actual designer surface info can be passed in and used to calculate the right TopLeft, Center etc values. Thoughts?

@CartBlanche CartBlanche force-pushed the dominique-OriginControl branch 6 times, most recently from bda18fc to 8689011 Compare September 12, 2019 13:01
CartBlanche
CartBlanche commented Sep 12, 2019
View reviewed changes
bot-provisioning/dependencies.csx
Item ("https://bosstoragemirror.blob.core.windows.net/wrench/jenkins/d16-0/50f7527307faf601c7b7754ac77a839fd5d0c820/26/package/xamarin.mac-5.6.0.25.pkg");
Item (XreItem.Xcode_10_0_0).XcodeSelect();
using System.Linq;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garuma I'm trying to update proppy to the latest. the Latest proj tag you mentioned didn't appear to help the build error on Mac. I may need some advice/direction with the provisioning as now getting error MSB4018: The "GenerateDepsFile" task failed unexpectedly. [/Users/vsts/agent/2.155.1/work/1/s/Xamarin.PropertyEditing/Xamarin.PropertyEditing.csproj] due to
error MSB4018: System.MissingMethodException: Method not found: System.Collections.Generic.IList`1<NuGet.Packaging.Core.PackageDependency> NuGet.ProjectModel.LockFileTargetLibrary.get_Dependencies()

Could it be a .NET Standard issue, rather than me trying to pull in .NET Core?

@CartBlanche CartBlanche force-pushed the dominique-OriginControl branch 2 times, most recently from f8848bf to ffc8489 Compare September 12, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermau ermau ermau left review comments

Assignees

@CartBlanche CartBlanche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mac] Origin Selector for Rectangles
2 participants
@CartBlanche @ermau