Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Auto-resizing editor #616

Open
ermau opened this issue Aug 27, 2019 · 7 comments
Open

Windows Auto-resizing editor #616

ermau opened this issue Aug 27, 2019 · 7 comments

Comments

@ermau
Copy link
Member

ermau commented Aug 27, 2019

image
image

@ermau
Copy link
Member Author

ermau commented Aug 28, 2019

@vancura Can we get some color guidance on this control for light/dark themes? We're moving over the original but it was not themed.

@vancura
Copy link
Contributor

vancura commented Aug 29, 2019

There are a couple of issues, especially in different spaces around the inner rectangle, lengths of each line and mainly about stroke width (it's centered 1pt and hence antialiased, semi-transparent). I'd like to properly design this editor, do we have time?

@ermau
Copy link
Member Author

ermau commented Sep 4, 2019

@vancura Only if you can get it to me this week and it doesn't represent a huge departure. I'll address the spacing issues, I just wanted to get a photo off to you to hopefully get some colors back quickly.

@vancura
Copy link
Contributor

vancura commented Sep 5, 2019

What do you think about this?

proppy@2x

Unfortunately we don't have the Autoresizing and Origin colors in the ColorService library, you'll need to create them in code or add new tokens.

Mac + Windows light theme colors:

  • grayscale dots and guidelines: #555555
  • red: #F56D4F

Mac + Windows dark theme colors:

  • grayscale dots and guidelines: #555555
  • red: #F56D4F (same as everywhere)

Windows dark theme colors:

  • grayscale dots and guidelines: #777777
  • red: #F56D4F (same as everywhere)

Thanks!

@ermau
Copy link
Member Author

ermau commented Sep 5, 2019

@vancura looks good to me, thanks!

@CartBlanche
Copy link
Contributor

@vancura That looks good! We also need colours for when the control is disabled? ATM I'm converting the "active" colours (the reds) to gray (different to your aforementioned grays) and leaving the rest as is. Looks ok, but something more inline with your design would be better, IMO.

@vancura
Copy link
Contributor

vancura commented Sep 25, 2019

The standard way is to make the control 50% opacity when disabled. Can you test this? I think that should be fine.

@ermau ermau added this to Core / Have Design in iOS Target Sep 27, 2019
@ermau ermau assigned ermau and unassigned ermau May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
iOS Target
  
Core / Have Design
Development

No branches or pull requests

3 participants