Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual updates 20230329 androidx.media.players #779

Open
wants to merge 125 commits into
base: main
Choose a base branch
from

Conversation

moljac
Copy link
Member

@moljac moljac commented Aug 28, 2023

Context:

New APIs for Media players. Needed by some MAUI components.

CommunityToolkit/Maui#1511

Does this change existing APIs?

Not existing., but yes - adds new APIs (packages bound)

  • androidx.media2.*
  • androidx.media3.*

Describe your contribution

New packages + dependencies

  • androidx.media2:media2-exoplayer - -> 1.3.0
  • androidx.media2:media2-player - -> 1.3.0
  • androidx.media3:media3-cast - -> 1.0.2
  • androidx.media3:media3-common - -> 1.0.2
  • androidx.media3:media3-database - -> 1.0.2
  • androidx.media3:media3-datasource - -> 1.0.2
  • androidx.media3:media3-datasource-cronet - -> 1.0.2
  • androidx.media3:media3-datasource-okhttp - -> 1.0.2
  • androidx.media3:media3-datasource-rtmp - -> 1.0.2
  • androidx.media3:media3-decoder - -> 1.0.2
  • androidx.media3:media3-effect - -> 1.0.2
  • androidx.media3:media3-exoplayer - -> 1.0.2
  • androidx.media3:media3-exoplayer-dash - -> 1.0.2
  • androidx.media3:media3-exoplayer-hls - -> 1.0.2
  • androidx.media3:media3-exoplayer-ima - -> 1.0.2
  • androidx.media3:media3-exoplayer-rtsp - -> 1.0.2
  • androidx.media3:media3-exoplayer-smoothstreaming - -> 1.0.2
  • androidx.media3:media3-exoplayer-workmanager - -> 1.0.2
  • androidx.media3:media3-extractor - -> 1.0.2
  • androidx.media3:media3-session - -> 1.0.2
  • androidx.media3:media3-transformer - -> 1.0.2
  • androidx.media3:media3-ui - -> 1.0.2
  • androidx.media3:media3-ui-leanback - -> 1.0.2
  • io.antmedia:rtmp-client - -> 3.2.0
  • com.google.android.gms:playservices-ads-identifier - -> 18.0.1
  • com.google.android.gms:playservices-ads-identifier - -> 18.0.1
  • com.google.android.gms:playservices-appset - -> 16.0.2
  • com.google.android.gms:playservices-base - -> 18.1.0
  • com.google.android.gms:playservices-cast-framework - -> 21.2.0
  • com.google.android.gms:playservices-cronet - -> 18.0.1
  • com.squareup.okhttp3:okhttp - -> 4.11.0
  • com.google.android.libraries.identity.googleid:googleid - -> 1.1.0

in GPS-FB-MLKit

  • com.google.ads.interactivemedia.v3:interactivemedia - -> 3.29.0

xamarin/GooglePlayServicesComponents#843

@moljac moljac self-assigned this Aug 28, 2023
@moljac moljac marked this pull request as draft August 28, 2023 09:53
@moljac moljac force-pushed the mu-20230329-androidx.media.players branch from 7d5eaa8 to 3c7af9a Compare October 1, 2023 09:40
@jonmdev
Copy link

jonmdev commented Apr 1, 2024

I've been working on cleaning up the metadata needed for this but it will take at least another day.

OK.

A good first step to getting this PR merged is to get a GPS PR going for com.google.ads.interactivemedia.v3.interactivemedia since we will need to get that committed and published before this PR can be committed.

I work on that one, but hitting number of projects limits with msbuild/xbuild on mac. I started rewriting cake scripts not to use old tools (MSBuild alias and DotNetMsBuild)

Thanks for all your work on this so far. Any estimate on when this (Media3) might be merged and available as a NuGet? I am starting a video project and it would be nice to use this rather than older methods. I can wait if needed but it would be helpful to know roughly how long it might be to judge whether waiting is feasible.

Thanks again.

@moljac moljac requested a review from jpobst April 30, 2024 19:56
Copy link
Contributor

@jpobst jpobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may be better off using the metadata/additions from #858.

This PR appears to remove too many things.

For example, it doesn't bind:

  • AndroidX.Media3.ExoPlayer.IExoPlayer
  • AndroidX.Media3.ExoPlayer.ExoPlayerBuilder

I don't think media3-exoplayer can be used without these types.

config.json Outdated
"version": "3.29.0",
"nugetVersion": "3.29.0",
"nugetId": "Xamarin.Google.Ads.InteractiveMedia.V3.InteractiveMedia",
"dependencyOnly": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dependencyOnly": true

@@ -334,7 +412,7 @@ AndroidX.Wear.WatchFace
AndroidX.Wear.WatchFace.Client
AndroidX.Wear.WatchFace.Complications
AndroidX.Wear.WatchFace.Complications.Data
AndroidX.Wear.WatchFace.Complications.Datasource
AndroidX.Wear.WatchFace.Complications.DataSource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to use metadata to manually put this one back as Datasource.

@@ -378,6 +456,10 @@ AndroidX.Work.Impl.Utils.Futures
AndroidX.Work.Impl.Utils.TaskExecutor
AndroidX.Work.Impl.Workers
AndroidX.Work.MultiProcess
Google.Ads.InteractiveMedia.V3.Api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will go away once it's set to dependencyOnly.

published-namespaces.txt Outdated Show resolved Hide resolved
@@ -1,2 +1,7 @@
<metadata>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need these changes to 5 media2-* files.

material are set forth below. Microsoft reserves all other rights not
expressly granted, whether by implication, estoppel or otherwise.

########################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

path="/api/package[@name='io.antmedia.rtmp_client']"
name="managedName"
>
Xamarin.IO.Antmedia.RTMP.Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rtmp


Note: This component depends on Google Tink [Google Tink](https://github.com/google/tink) which is subject to the [Apache 2.0](https://github.com/ReactiveX/RxJava/blob/2.x/LICENSE)

### Xamarin Component for Google Tink for Xamarin.Android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

A description of the package and where one can find more documentation
-->

Google Tink NuGet Package @(Model.NuGetPackageId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@moljac
Copy link
Member Author

moljac commented May 1, 2024

I think we may be better off using the metadata/additions from #858.

This PR appears to remove too many things.

For example, it doesn't bind:

  • AndroidX.Media3.ExoPlayer.IExoPlayer
  • AndroidX.Media3.ExoPlayer.ExoPlayerBuilder

I don't think media3-exoplayer can be used without these types.

I think you reviewed wrong PR (maybe I contributed to confusion)

I did not ask for review of this one yet, because I it is not finished yet.

I asked for review of Weekly stable updates

#878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind "androidx.media3"
4 participants