Removing a <movietexture> dynamically causes errors.

[microaaron]

Removing a <movietexture> dynamically causes errors.

Uncaught TypeError: Failed to execute 'texImage2D' on 'WebGL2RenderingContext': Overload resolution failed.
at updateMovie (x3dom.debug.js:21188:16)

x3dom/src/Texture.js

Line 449 in 23bb157

gl.texImage2D( that.type, 0, that.format, that.format, gl.UNSIGNED_BYTE, tex._video );

[andreasplesch]

I think this happens because the <video> DOM element is removed without emitting an ended event. .pause() in shutdown should cause an ended event. ended may only be emitted after a video started to play. If there is no user interaction it does not start to play.

[andreasplesch]

It turns out that shutdown actually should not cause an ended playing event because it should not try to loop the video. It seems easiest to just remove the updating in shutdown. I will also add better IOS compatibility, and better auto-starting.

[microaaron]

Thanks.

[microaaron]

This error still exists.

x3dom/src/Texture.js

Line 449 in 23bb157

gl.texImage2D( that.type, 0, that.format, that.format, gl.UNSIGNED_BYTE, tex._video );

tex._video=null

Since the MovieTexture is removed, why is updateMovie() still being executed? It seems that in opengl the texture is not destroyed.

[andreasplesch]

I could reproduce on Linux, Chrome 103.0.5060.53 . I had only tested on Windows, latest Chrome where it worked. What platform did you use ?

[microaaron]

I could reproduce on Linux, Chrome 103.0.5060.53 . I had only tested on Windows, latest Chrome where it worked. What platform did you use ?

Windows10, Chrome 102.0.5005.115, Microsoft Edge 103.0.1264.71, Firefox 103.0

[microaaron]

setInterval() is called twice. line 470 and line 478.

x3dom/src/Texture.js

Lines 465 to 479 in 835ef69

	var startVideo = function ()
	{
	tex._video.play()
	.then( function fulfilled ()
	{
	tex._intervalID = setInterval( updateMovie, 16 );
	} )
	.catch( function rejected ( err )
	{
	x3dom.debug.logInfo( "retrying: " + err );
	setTimeout( startVideo, tex._video.retryInterval );
	tex._video.retryInterval *= 1.0 + tex._video.retryGrowth;
	} );
	tex._intervalID = setInterval( updateMovie, 16 );
	};

#1228

[microaaron]

And...Wouldn't it be better for the second parameter of setInterval() to match the frame rate of the video?

[andreasplesch]

Thx, a copy and paste mistake.

…

---on the phone---

On Thu, Jul 28, 2022, 3:50 AM microaaron ***@***.***> wrote: setInterval() is called twice. https://github.com/x3dom/x3dom/blob/835ef694bd3c150d7d819029321525f928dc6da9/src/Texture.js#L465-L479 ##1228 <#1228> — Reply to this email directly, view it on GitHub <#1226 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPCT227UH2N7EJQG74N3TTVWI3VZANCNFSM54O7FNMA> . You are receiving this because you commented.Message ID: ***@***.***>

[microaaron]

Firefox reported two warnings:
WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER.
WebGL warning: readPixels: Out-of-bounds reads with readPixels are deprecated, and may be slow.

[andreasplesch]

And...Wouldn't it be better for the second parameter of setInterval() to match the frame rate of the video?

Ideally, yes. https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/playbackRate is only relative to the native file rate. Maybe there is a way to determine the file rate.

[andreasplesch]

c4a27a8