Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IonCollection.radiative_loss should include continuum contributions #232

Open
wtbarnes opened this issue Apr 3, 2023 · 0 comments · May be fixed by #282
Open

IonCollection.radiative_loss should include continuum contributions #232

wtbarnes opened this issue Apr 3, 2023 · 0 comments · May be fixed by #282
Labels
effort-medium IonCollection Anything related to the IonCollection object

Comments

@wtbarnes
Copy link
Owner

wtbarnes commented Apr 3, 2023

The radiative_loss function should optionally include the continuum contribution from each ion. This could be done as a final step (outside of the main loop) by just calling the appropriate continuum methods on IonCollection.

The one issue is how to handle the wavelength dependence. Currently, radiative_loss does not require a wavelength and just sums over every single transition in the ion. However, the continuum methods all require a wavelength. One option would be to have a default wavelength argument (e.g. 1-5000 Å) and then always only include the line transitions that fall within that wavelength range. This would make computing radiative losses for only particular wavelength ranges much easier.

@wtbarnes wtbarnes added effort-medium IonCollection Anything related to the IonCollection object labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-medium IonCollection Anything related to the IonCollection object
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant