Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DEM file parsing #230

Open
wtbarnes opened this issue Mar 17, 2023 · 0 comments
Open

Simplify DEM file parsing #230

wtbarnes opened this issue Mar 17, 2023 · 0 comments
Labels
effort-low Good First Issue The best issues for new people to tackle! I/O

Comments

@wtbarnes
Copy link
Owner

wtbarnes commented Mar 17, 2023

Currently, I have a bunch of complicated code that tries to parse out the edges and widths in order to get the emission measure distribution from the differential emission measure distribution. This should just be simplified to compute the EM from the DEM using a simple gradient of the temperature array, e.g.

em = np.gradient(temperature_bin_centers) * dem

There's no real reliable way to get the bin edges so we should not pretend to be able to reliably parse that information. This also means that all datasets have the same number of columns which is preferable.

@wtbarnes wtbarnes added this to the 0.2 milestone Apr 3, 2023
@wtbarnes wtbarnes added effort-low I/O Good First Issue The best issues for new people to tackle! labels Jan 12, 2024
@wtbarnes wtbarnes removed this from the 0.3 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-low Good First Issue The best issues for new people to tackle! I/O
Projects
None yet
Development

No branches or pull requests

1 participant