Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless PHP unit tests for multisites? #511

Open
IanDelMar opened this issue Feb 4, 2021 · 0 comments
Open

Useless PHP unit tests for multisites? #511

IanDelMar opened this issue Feb 4, 2021 · 0 comments

Comments

@IanDelMar
Copy link
Collaborator

The Travis contains a WP_MULTISITE=1 variable for both the matrix environment variables and the include environment variables.

env:
- WP_VERSION=latest WP_MULTISITE=0 PHPUNIT_VERSION="^5.7"
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7"

- php: 7.0
dist: xenial
env:
- WP_VERSION=latest WP_MULTISITE=1 PHPUNIT_VERSION="^5.7"

While the other variables, WP_VERSION and PHPUNIT_VERSION, are used, I don't see that WP_MULTISITE is used anywhere.
install:
- bin/install-wp-tests.sh wordpress_test root "" localhost "${WP_VERSION}"
- composer global require --dev "phpunit/phpunit=${PHPUNIT_VERSION}"

Additionally, the test file does not include any multisite tests. I think that all unit test with WP_MULTISITE=1 are duplicates of their WP_MULTISITE=0 versions and should be removed as they increase Travis build times and unnecessarily use Travis resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant