Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Make autofill compatible with updated address fields display logic #47586

Open
nielslange opened this issue May 17, 2024 · 0 comments
Labels
block: checkout Issues related to the checkout block. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.

Comments

@nielslange
Copy link
Member

Describe the solution you'd like

In #47160, we've updated the address fields display logic. As a result of that, it's now possible that the Address line 2 field is hidden behind a link. In this case, autofill would not work for this field, as it only becomes available when the link is clicked. It's also not available in the DOM. This issue aims to enable autofill for the hidden Address line 2 field. In #47160 (review), @senadir mentioned the following:

One way we did autofill before was to render a hidden input (not sure if type hidden or just visually hidden) that would capture the autofill value, if captured, it will expand the actual field and fill it with that value.

Describe alternatives you've considered

No response

Additional context

No response

@nielslange nielslange added type: enhancement The issue is a request for an enhancement. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues block: checkout Issues related to the checkout block. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: checkout Issues related to the checkout block. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant