Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change minimum version of CryptoSwift dependency to 1.8.0 #846

Open
g1umov opened this issue Feb 10, 2024 · 3 comments
Open

change minimum version of CryptoSwift dependency to 1.8.0 #846

g1umov opened this issue Feb 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@g1umov
Copy link

g1umov commented Feb 10, 2024

What context is your feature request related to?

There is an dependencies resolving issue within SPM package in my iOS project. For example, try to add 'SwiftLint' and 'web3swift' dependencies into a package and you will see the following error message:

'Failed to resolve dependencies Dependencies could not be resolved because 'core' depends on 'swiftlint' 0.54.0..<1.0.0 and 'core' depends on 'web3swift' 3.2.0..<4.0.0.
'web3swift' is incompatible with 'swiftlint' because 'swiftlint' 0.54.0 depends on 'cryptoswift' 1.8.0..<1.9.0 and no versions of 'swiftlint' match the requirement 0.54.1..<1.0.0.
'web3swift' >= 3.2.0 practically depends on 'cryptoswift' 1.5.1..<1.6.0 because no versions of 'web3swift' match the requirement 3.2.1..<4.0.0 and 'web3swift' 3.2.0 depends on 'cryptoswift' 1.5.1..<1.6.0.'

What solution would you like?

I suggest to change min version of the 'CryptoSwift' dependency to 1.8.0

Any additional context?

No response

@g1umov g1umov added the enhancement New feature or request label Feb 10, 2024
g1umov pushed a commit to g1umov/web3swift that referenced this issue Feb 10, 2024
The minimum version of 1.5.1 is too small. These changes resolve dependency conflicts that have the 'CryptoSwift' dependency within the SPM package
g1umov pushed a commit to g1umov/web3swift that referenced this issue Feb 10, 2024
The minimum version of 1.5.1 is too small. These changes resolve dependency conflicts that have the 'CryptoSwift' dependency within the SPM package
@yaroslavyaroslav
Copy link
Collaborator

Hi, thanks for an issue and the PR for the project. Just wonder what is the purpose of including SwiftLint dependency in your app?

@g1umov
Copy link
Author

g1umov commented Feb 11, 2024

Hi, I use the SwiftLint dependency as a plugin for some targets in the package.

@yaroslavyaroslav
Copy link
Collaborator

Yeah, seems legit. Although this given fix fixes the issue, I'm worried that it's so until the next swiftlint & crypto swift update, which is not ok in general.

@JeneaVranceanu have we considered to drop this dependency in the past?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants