Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: description of transaction doesn't return from #766

Open
janndriessen opened this issue Feb 9, 2023 · 1 comment
Open

Minor: description of transaction doesn't return from #766

janndriessen opened this issue Feb 9, 2023 · 1 comment
Labels

Comments

@janndriessen
Copy link
Collaborator

What piece of the framework are having the lack of docs?

The from field on transaction is not returned as expected when calling a description on a transaction.

To reproduct:

  • Call description on a transaction that has the from field set.

You can see here that the issue that only sender is return as from when set: https://github.com/web3swift-team/web3swift/blob/develop/Sources/Web3Core/Transaction/CodableTransaction.swift#L274

What bit of docs would you like to have?

In general whoever takes this ticket could look at improving the description of a transaction.

@albertopeam
Copy link
Contributor

albertopeam commented Feb 20, 2023

PR #783 opened
@janndriessen Could you take a look? If the purpose was wrongly understood let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants