[DRAFT] 100% Coverage web3-utills #7042
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 12b198b | Previous: 9086b98 | Ratio |
|---|---|---|---|
processingTx |
9180 ops/sec (±4.04%) |
9425 ops/sec (±3.89%) |
1.03 |
processingContractDeploy |
37943 ops/sec (±8.17%) |
40876 ops/sec (±7.53%) |
1.08 |
processingContractMethodSend |
20109 ops/sec (±7.15%) |
20109 ops/sec (±6.99%) |
1 |
processingContractMethodCall |
39245 ops/sec (±6.49%) |
40926 ops/sec (±6.33%) |
1.04 |
abiEncode |
43698 ops/sec (±6.84%) |
46401 ops/sec (±6.86%) |
1.06 |
abiDecode |
30072 ops/sec (±8.65%) |
31387 ops/sec (±7.92%) |
1.04 |
sign |
1544 ops/sec (±3.57%) |
1581 ops/sec (±3.62%) |
1.02 |
verify |
373 ops/sec (±0.62%) |
384 ops/sec (±0.33%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7042 +/- ##
==========================================
+ Coverage 92.17% 94.14% +1.96%
==========================================
Files 215 215
Lines 8335 8328 -7
Branches 2301 2297 -4
==========================================
+ Hits 7683 7840 +157
+ Misses 652 488 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luu-alex
changed the title
| @@ -74,11 +72,7 @@ const findSchemaByDataPath = ( | |||
| result = (result.properties as Record<string, JsonSchema>)[dataPart]; | |||
| } else if (result.items && (result.items as JsonSchema).properties) { | |||
| const node = (result.items as JsonSchema).properties as Record<string, JsonSchema>; | |||
|
|
|||
| if (!node) { | |||
There was a problem hiding this comment.
we remove this
this conditional can never be met,
} else if (result.items && (result.items as JsonSchema).properties) {
we make sure result.properties always exists
| @@ -57,10 +57,8 @@ const findSchemaByDataPath = ( | |||
|
|
|||
| for (const dataPart of dataPath) { | |||
| if (result.oneOf && previousDataPath) { | |||
| const path = oneOfPath.find(function (element: [string, number]) { | |||
There was a problem hiding this comment.
changed this for readability
| clearInterval(intervalId); | ||
| resolve(res as unknown as Exclude<T, undefined>); | ||
| reject(error); |
There was a problem hiding this comment.
this file was changed from prettier
|
Some lines were not covered as |
|
Looking into the format tests right now and trying to make them work |
Description
Fixes #7031
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.