Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option only synchronize brightness changes triggered externally #2969

Closed
acocoadog opened this issue May 15, 2024 · 8 comments
Closed

Add option only synchronize brightness changes triggered externally #2969

acocoadog opened this issue May 15, 2024 · 8 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request released Released sync various forms of syncing
Milestone

Comments

@acocoadog
Copy link

In the newly added Groups feature, if it is possible to provide an option "only synchronize brightness changes triggered externally" to avoid synchronizing brightness through the app's shortcut keys? Because sometimes I only want the brightness of the light sensor to be synchronized to the external display, and I want the external display and the built-in display to be able to adjust the brightness independently.

In addition, if the cover of MacBook is closed when the brightness synchronization function is turned on, the brightness of the external screen will drop unexpectedly, but I think most people hope that the brightness will not change at this time.

I hope the above suggestions will be helpful to you.

@waydabber waydabber added enhancement New feature or request sync various forms of syncing labels May 15, 2024
@waydabber
Copy link
Owner

Hi there, yes, both are possible. And indeed, the brightness of the external display should not drop when the lid is closed, that is a bug.

@waydabber waydabber changed the title Some optimizations of Brightness Synchronization Function Add option only synchronize brightness changes triggered externally May 15, 2024
@waydabber
Copy link
Owner

waydabber commented May 15, 2024

Hey @acocoadog - I can't seem to be able to reproduce the issue with closing the MacBook display. Can you give some more details on your setup and how syncing is configured exactly so I may try to reproduce this problem? Thank you!

@waydabber
Copy link
Owner

Ok, I was able to reproduce the problem. This happens only when auto brightness is enabled.

@waydabber
Copy link
Owner

This option is visible when syncing external changes is enabled:

Screenshot 2024-05-15 at 16 42 26

@waydabber waydabber self-assigned this May 15, 2024
@waydabber waydabber added the in progress Implementing label May 15, 2024
@waydabber waydabber added this to the v2.3.4 milestone May 15, 2024
@acocoadog
Copy link
Author

👍

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels May 15, 2024
@waydabber
Copy link
Owner

Here is an interim build with this feature (+ some bug fixes for syncing and other things):

https://github.com/waydabber/BetterDisplay/releases/download/v2.0.0-pre-release/BetterDisplay-v2.3.4-b29903-pre.zip

@acocoadog
Copy link
Author

This is great! Perfectly solved my problem.
In addition, if you need Chinese translation of this option, you can refer to the following.

Synchronize external changes only
仅同步外部触发的亮度变化
Do not synchronize brightness changes made using the app.
使用本应用程序进行的亮度调整不会同步。

@waydabber
Copy link
Owner

Thanks! :)

@waydabber waydabber added the released Released label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request released Released sync various forms of syncing
Projects
None yet
Development

No branches or pull requests

2 participants