Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace antlr4 deps with antlr4-runtime #454

Open
namenu opened this issue Feb 11, 2024 · 2 comments · May be fixed by #459
Open

Replace antlr4 deps with antlr4-runtime #454

namenu opened this issue Feb 11, 2024 · 2 comments · May be fixed by #459
Labels
enhancement
Milestone
1.3.0

Comments

@namenu
Copy link
Contributor

namenu commented Feb 11, 2024 •
edited

The ANTLR used in the parser is a very large and heavy library, taking up around 50MB when unjarred.
This makes it difficult to use Lacinia easily with AWS Lambda, etc.

Therefore, I propose to replace ANTLR with the antlr4-runtime dependency rather than the whole thing. To do this, clj-antlr needs to be removed and pre-generated java code should be interop-ed instead.
@namenu
Copy link
Contributor Author

namenu commented Feb 14, 2024

I've worked on it here green-labs#6 and it works well in our fairly complex schema.
I'd be interested to know what you think! @hlship

@hlship
Copy link
Member

hlship commented Feb 15, 2024

I'm very interested in this; it's just a bit big for a bug fix release, so it'll wait for 1.3 rather than 1.2.x.
I don't mind mixing a little bit of Java into my lovely Clojure code ... if there's a big payoff!

@hlship hlship added this to the 1.3.0 milestone Mar 5, 2024
@namenu namenu linked a pull request Apr 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Bundle precompiled antlr parser green-labs/lacinia
2 participants
@hlship @namenu