Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestTimeout should be added back in Azure BlobClient package #223

Open
plameniv opened this issue Apr 6, 2021 · 0 comments
Open

requestTimeout should be added back in Azure BlobClient package #223

plameniv opened this issue Apr 6, 2021 · 0 comments
Labels
bug Something isn't working M-azure This issue is related to the Azure module P2 Priority 2
Milestone

Comments

@plameniv
Copy link
Collaborator

plameniv commented Apr 6, 2021

The requestTimeout parameter of the IBlobStorageConfiguration has been removed. It used to be passed to the createBlockBlobFromText of the BlobService from the azure-storage package.

This parameter is no longer used during the blob creation coming from package @azure/storage-blob however it can be passed in the constructor for BlobServiceClient as part of StoragePipelineOptions

constructor(url: string, credential?: StorageSharedKeyCredential | AnonymousCredential | TokenCredential, options?: StoragePipelineOptions);

StoragePipelineOptions has a field retryOptions of type StorageRetryOptions which has the tryTimeoutInMs field.

We can add the timeout back in.

@plameniv plameniv added bug Something isn't working M-azure This issue is related to the Azure module labels Apr 6, 2021
@plameniv plameniv added this to the 1.4 milestone Apr 6, 2021
@plameniv plameniv added the P2 Priority 2 label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working M-azure This issue is related to the Azure module P2 Priority 2
Development

No branches or pull requests

1 participant